Date: Mon, 06 Oct 2014 00:36:35 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-testing@freebsd.org Subject: [Bug 193499] [tests] usr.bin/yacc/err_syntax27.error failures with the latest kyua Message-ID: <bug-193499-32464-yXTHdkJ5Hw@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-193499-32464@https.bugs.freebsd.org/bugzilla/> References: <bug-193499-32464@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193499 dickey@his.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dickey@his.com --- Comment #9 from dickey@his.com --- I made a different change on Thursday, using calloc to allocate the line data. That's overkill. At the same time, I had promised to make %parse-param work with %destructor, and had started that. So I've been working on this (and aside from retesting, static analysis) and "done". However, I took a look at this change (undoing the calloc), and it did not (for whatever reason) entirely fix the valgrind warnings. In my current code, I got this (with btyacc_demo.y): ==11640== 2 errors in context 1 of 2: ==11640== Invalid write of size 1 ==11640== at 0x4095DB: get_line (reader.c:137) ==11640== by 0x4097B6: nextc (reader.c:261) ==11640== by 0x40B04A: copy_destructor (reader.c:2703) ==11640== by 0x40BDEA: read_declarations (reader.c:1564) ==11640== by 0x40DF64: reader (reader.c:3433) ==11640== by 0x404BBE: main (main.c:692) ==11640== Address 0x518e7b5 is 0 bytes after a block of size 101 alloc'd ==11640== at 0x4C244E8: malloc (vg_replace_malloc.c:236) ==11640== by 0x4095A9: get_line (reader.c:128) ==11640== by 0x409664: next_inline (reader.c:215) ==11640== by 0x409759: nextc (reader.c:258) ==11640== by 0x40B28A: read_declarations (reader.c:1502) ==11640== by 0x40DF64: reader (reader.c:3433) ==11640== by 0x404BBE: main (main.c:692) I did use valgrind to spot the problem in err_syntax27.y, so we're talking about the same original report. Anyway, since I have a working fix, I'll continue with that. (thanks for the feedback) -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193499-32464-yXTHdkJ5Hw>