Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 13 Dec 2009 20:36:43 +0000 (UTC)
From:      Marius Strobl <marius@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r200485 - head/sys/dev/ata/chipsets
Message-ID:  <200912132036.nBDKahGa096564@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: marius
Date: Sun Dec 13 20:36:42 2009
New Revision: 200485
URL: http://svn.freebsd.org/changeset/base/200485

Log:
  Only set ATA_CHECKS_CABLE for chip versions that actually support
  cable detection, i.e. neither for ALI_OLD nor for ALI_NEW revisions
  >= 0xc7.
  
  MFC after:	1 week

Modified:
  head/sys/dev/ata/chipsets/ata-acerlabs.c

Modified: head/sys/dev/ata/chipsets/ata-acerlabs.c
==============================================================================
--- head/sys/dev/ata/chipsets/ata-acerlabs.c	Sun Dec 13 20:27:59 2009	(r200484)
+++ head/sys/dev/ata/chipsets/ata-acerlabs.c	Sun Dec 13 20:36:42 2009	(r200485)
@@ -180,7 +180,8 @@ ata_ali_ch_attach(device_t dev)
     if (ata_pci_ch_attach(dev))
 	return ENXIO;
 
-    ch->flags |= ATA_CHECKS_CABLE;
+    if (ctlr->chip->cfg2 & ALI_NEW && ctlr->chip->chiprev < 0xc7)
+	ch->flags |= ATA_CHECKS_CABLE;
     /* older chips can't do 48bit DMA transfers */
     if (ctlr->chip->chiprev <= 0xc4)
 	ch->flags |= ATA_NO_48BIT_DMA;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200912132036.nBDKahGa096564>