Date: Thu, 8 Nov 2018 13:11:24 +0300 From: Oleg Bulyzhin <oleg@FreeBSD.org> To: freebsd-net@FreeBSD.org Subject: ix0 (iflib) vlans @ head & 12-stable Message-ID: <20181108101124.GB80723@lath.rinet.ru>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
While testing 12-stable i've found following:
current ixgbe driver is using iflib and has IFCAP_VLAN_HWFILTER
enabled by default.
/sys/net/iflib.c iflib_vlan_[un]register() functions have this code:
/* Re-init to load the changes */
if (if_getcapenable(ifp) & IFCAP_VLAN_HWFILTER)
iflib_if_init_locked(ctx);
Thus any vlan reconfiguration leads to link flap. This is not
how it was before iflib conversion.
I'm not sure about other vlanhwfilter aware hardware but
intel x520-da2 cards (82599 chip) does not require re-init
after hwfilter reconfig.
Should we extend iflib framework a bit?
--
Oleg.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iHUEARYKAB0WIQRU3IiAS5hzxBjDaSalDfmDDe+xhwUCW+QLxQAKCRClDfmDDe+x
hyyTAQCrE6c7zqXjGLT+5xUU5VQsueJyNY0nsHWUFOlHb67wgAD8DI80leULEJIg
BnvhiGj76APp33JPa0+LIDOgisPVPws=
=veyq
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181108101124.GB80723>