Date: Tue, 28 May 2019 18:31:34 +0100 From: Ruslan Bukin <br@freebsd.org> To: Emmanuel Vadot <manu@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r347930 - head/sys/dev/pci Message-ID: <20190528173134.GA94573@bsdpad.com> In-Reply-To: <201905171705.x4HH5HDR059483@repo.freebsd.org> References: <201905171705.x4HH5HDR059483@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 17, 2019 at 05:05:17PM +0000, Emmanuel Vadot wrote: > Author: manu > Date: Fri May 17 17:05:16 2019 > New Revision: 347930 > URL: https://svnweb.freebsd.org/changeset/base/347930 > > Log: > pci: ecam: Correctly parse memory and IO region > > When activating a resource do not compare the resource id to the adress. > Treat IO region as MEMORY region too. > > Submitted by: Tuan Phan <tphan@amperecomputing.com> (Original Version) > Sponsored by: Ampere Computing, LLC > Differential Revision: https://reviews.freebsd.org/D20214 > > Modified: > head/sys/dev/pci/pci_host_generic.c > head/sys/dev/pci/pci_host_generic_acpi.c > > Modified: head/sys/dev/pci/pci_host_generic_acpi.c > ============================================================================== > --- head/sys/dev/pci/pci_host_generic_acpi.c Fri May 17 17:04:01 2019 (r347929) > +++ head/sys/dev/pci/pci_host_generic_acpi.c Fri May 17 17:05:16 2019 (r347930) > @@ -293,7 +291,7 @@ pci_host_generic_acpi_attach(device_t dev) > continue; /* empty range element */ > if (sc->base.ranges[tuple].flags & FLAG_MEM) { > error = rman_manage_region(&sc->base.mem_rman, > - phys_base, phys_base + size - 1); > + pci_base, pci_base + size - 1); > } else if (sc->base.ranges[tuple].flags & FLAG_IO) { > error = rman_manage_region(&sc->base.io_rman, > pci_base + PCI_IO_WINDOW_OFFSET, > Don't we need to make a similar change to pci_host_generic_fdt.c ? Ruslan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190528173134.GA94573>