Date: Sun, 4 Nov 2012 00:52:54 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Andre Oppermann <oppermann@networx.ch> Cc: net@FreeBSD.org Subject: Re: splitting m_flags to pkthdr.flags + m_flags Message-ID: <20121103205254.GX70741@glebius.int.ru> In-Reply-To: <5093C29A.4020902@networx.ch> References: <20121102123817.GP70741@FreeBSD.org> <5093C29A.4020902@networx.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Nov 02, 2012 at 01:54:50PM +0100, Andre Oppermann wrote: A> > An attentive reader may have noticed that I missed M_NOFREE and M_FREELIST. A> > Yep, these flags coming from historical mbuf allocator from FreeBSD 4.x times A> > are about to be deleted, we carefully examine them, but never set. Patch A> > for review attached. A> A> Looks good. Go ahead from me. History review reveals that M_NOFREE comes from r172463 by Kip Macy. The idea was to have mbufs embdedded into clusters. The feature isn't used by any module and isn't tested at all. I ponder on should we leave the code as is or not? M_FREELIST actually has nothing to do with historic mbuf allocator. It was a bandaid that helped to debug double-frees. The code was washed out from the repo, only the flag left. Also the functionality is now available via generic allocator invariants. So M_FREELIST definitely should be deleted. But I'm not sure about M_NOFREE. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121103205254.GX70741>