Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 Sep 2017 15:59:21 +0000 (UTC)
From:      Alan Somers <asomers@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r323445 - projects/zfsd/head/tests/sys/cddl/zfs/bin
Message-ID:  <201709111559.v8BFxLdM006320@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: asomers
Date: Mon Sep 11 15:59:20 2017
New Revision: 323445
URL: https://svnweb.freebsd.org/changeset/base/323445

Log:
  Fix intermittency in refquota_002_pos from the ZFS test suite
  
  tests/sys/cddl/zfs/bin/mkfile.c
  	Don't unlink a file when unable to write the entire thing.  Nothing
  	in the ZFS test suite depends on that behavior.  However, a few
  	tests (like refquota_002_pos) depend on the opposite.  Right now
  	refquota_002_pos only passes sometimes because unlink(2) loses a
  	race against "zfs get used".
  
  Sponsored by:	Spectra Logic Corp

Modified:
  projects/zfsd/head/tests/sys/cddl/zfs/bin/mkfile.c

Modified: projects/zfsd/head/tests/sys/cddl/zfs/bin/mkfile.c
==============================================================================
--- projects/zfsd/head/tests/sys/cddl/zfs/bin/mkfile.c	Mon Sep 11 15:56:07 2017	(r323444)
+++ projects/zfsd/head/tests/sys/cddl/zfs/bin/mkfile.c	Mon Sep 11 15:59:20 2017	(r323445)
@@ -204,7 +204,6 @@ main(int argc, char *argv[])
 	while (++argv, --argc) {
 		if (create_file(*argv, fsize) == -1) {
 			perror(*argv);
-			unlink(*argv);
 			return EXIT_FAILURE;
 		}
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201709111559.v8BFxLdM006320>