Date: Fri, 1 Jun 2018 11:24:20 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Jan Knepper <jan@digitaldaemon.com> Cc: Ian Lepore <ian@freebsd.org>, "rb@gid.co.uk" <rb@gid.co.uk>, "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> Subject: RE: PRs are being closed for bogus reasons :-( Message-ID: <20180601182415.BC182799@spqr.komquats.com>
index | next in thread | raw e-mail
Nope. Last year. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert <Cy.Schubert@cschubert.com> or <cy@freebsd.org> The need of the many outweighs the greed of the few. --- -----Original Message----- From: Jan Knepper Sent: 01/06/2018 11:06 To: Cy Schubert Cc: Ian Lepore; rb@gid.co.uk; freebsd-hackers@freebsd.org Subject: Re: PRs are being closed for bogus reasons :-( That sounds like a patch (HACK!) I submitted years (10+?} ago to have multiple IPv4 addresses in a jail... :-) It was indeed not IPv6 ready... Jan ManiaC++ Jan Knepper > On Jun 1, 2018, at 13:37, Cy Schubert <Cy.Schubert@cschubert.com> wrote: > > Yes. Let me relay my experience. I received an IPv4 only hack (I hesitate to call it a patch). Reworking the submission to fix the immediate issue and incrementally addresses IPv6 was unsatisfactory to the OP, as his suggested solution would have removed support for IPv6 entirely: his reply was he didn't use IPv6. > > As a committer when sheepherding patches, one must consider the whole, not someone's immediate beef. I've had many more experiences like this in ports where one change might satisfy one locale while becoming a POLA violation for the rest of the community. Unfortunately when the answer is no or let's try a compromise, feelings get hurt. > > --- > Sent using a tiny phone keyboard. > Apologies for any typos and autocorrect. > Also, this old phone only supports top post. Apologies. > > Cy Schubert > <Cy.Schubert@cschubert.com> or <cy@freebsd.org> > The need of the many outweighs the greed of the few. > --- > > -----Original Message----- > From: Ian Lepore > Sent: 01/06/2018 08:18 > To: rb@gid.co.uk > Cc: freebsd-hackers@freebsd.org > Subject: Re: PRs are being closed for bogus reasons :-( > > On Fri, 2018-06-01 at 15:53 +0100, rb@gid.co.uk wrote: >>> >>> On 1 Jun 2018, at 15:41, Warner Losh <imp@bsdimp.com> wrote: >>> >>>> >>>> On Fri, Jun 1, 2018 at 8:10 AM, Bob Bishop <rb@gid.co.uk> wrote: >>>> Hi, >>>> >>>>> >>>>> On 31 May 2018, at 22:14, Poul-Henning Kamp <phk@phk.freebsd.dk> wrote: >>>>> >>>>> -------- >>>>> In message >>>>> , Warner Losh writes: >>>>> >>>>>> >>>>>> There's a problem with the PR database: there's too many bugs. >>>>> And despite the valiant efforts of a number of people over the >>>>> lifetime of the project, it has always had so many bugs that >>>>> everybody just threw their hands in the air and walked away. >>>>> >>>>> The way to improve the situation is to fix PR's, not to complain >>>>> about PRs. >>>> Indeed. But look at the number of PRs with patches that are stuck in that state. Not pretty. >>> Over the years I've committed dozens of PRs that had patches in them. The sad truth is that only about 10-15% of them have comitable patches in them when submitted. And that number decays over time as things age in bugzilla. [etc] >> Sure. But the best a non-comitter can do is to supply a patch tested against HEAD. If the patch rots because it hasn¢t been committed six months down the line it¢s not my fault. >> > > The problem isn't bitrot, the problem is that many patches amount to > "here's a hack that works for me," and that isn't necessarily > committable. A committer typically has to do almost as much work to > figure out whether the patch is appropriate for all users on all arches > as they would have to do to develop a fix from scratch. Even if the > submitter has mad skills and submits a perfect patch, better than what > the committer would have done from scratch, the work to analyze > everything and decide whether that's the case still has to be done. > > -- Ian > > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180601182415.BC182799>