Date: Fri, 1 Jun 2018 11:24:20 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Jan Knepper <jan@digitaldaemon.com> Cc: Ian Lepore <ian@freebsd.org>, "rb@gid.co.uk" <rb@gid.co.uk>, "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> Subject: RE: PRs are being closed for bogus reasons :-( Message-ID: <20180601182415.BC182799@spqr.komquats.com>
next in thread | raw e-mail | index | archive | help
Nope. Last year. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert <Cy.Schubert@cschubert.com> or <cy@freebsd.org> The need of the many outweighs the greed of the few. --- -----Original Message----- From: Jan Knepper Sent: 01/06/2018 11:06 To: Cy Schubert Cc: Ian Lepore; rb@gid.co.uk; freebsd-hackers@freebsd.org Subject: Re: PRs are being closed for bogus reasons :-( That sounds like a patch (HACK!) I submitted years (10+?} ago to have multi= ple IPv4 addresses in a jail... :-) It was indeed not IPv6 ready... Jan ManiaC++ Jan Knepper > On Jun 1, 2018, at 13:37, Cy Schubert <Cy.Schubert@cschubert.com> wrote: >=20 > Yes. Let me relay my experience. I received an IPv4 only hack (I hesitate= to call it a patch). Reworking the submission to fix the immediate issue a= nd incrementally addresses IPv6 was unsatisfactory to the OP, as his sugges= ted solution would have removed support for IPv6 entirely: his reply was he= didn't use IPv6. >=20 > As a committer when sheepherding patches, one must consider the whole, no= t someone's immediate beef. I've had many more experiences like this in por= ts where one change might satisfy one locale while becoming a POLA violatio= n for the rest of the community. Unfortunately when the answer is no or let= 's try a compromise, feelings get hurt. >=20 > --- > Sent using a tiny phone keyboard. > Apologies for any typos and autocorrect. > Also, this old phone only supports top post. Apologies. >=20 > Cy Schubert > <Cy.Schubert@cschubert.com> or <cy@freebsd.org> > The need of the many outweighs the greed of the few. > --- >=20 > -----Original Message----- > From: Ian Lepore > Sent: 01/06/2018 08:18 > To: rb@gid.co.uk > Cc: freebsd-hackers@freebsd.org > Subject: Re: PRs are being closed for bogus reasons :-( >=20 > On Fri, 2018-06-01 at 15:53 +0100, rb@gid.co.uk wrote: >>>=20 >>> On 1 Jun 2018, at 15:41, Warner Losh <imp@bsdimp.com> wrote: >>>=20 >>>>=20 >>>> On Fri, Jun 1, 2018 at 8:10 AM, Bob Bishop <rb@gid.co.uk> wrote: >>>> Hi, >>>>=20 >>>>>=20 >>>>> On 31 May 2018, at 22:14, Poul-Henning Kamp <phk@phk.freebsd.dk> wrot= e: >>>>>=20 >>>>> -------- >>>>> In message=20 >>>>> , Warner Losh writes: >>>>>=20 >>>>>>=20 >>>>>> There's a problem with the PR database: there's too many bugs. >>>>> And despite the valiant efforts of a number of people over the >>>>> lifetime of the project, it has always had so many bugs that >>>>> everybody just threw their hands in the air and walked away. >>>>>=20 >>>>> The way to improve the situation is to fix PR's, not to complain >>>>> about PRs. >>>> Indeed. But look at the number of PRs with patches that are stuck in t= hat state. Not pretty. >>> Over the years I've committed dozens of PRs that had patches in them. T= he sad truth is that only about 10-15% of them have comitable patches in th= em when submitted. And that number decays over time as things age in bugzil= la. [etc] >> Sure. But the best a non-comitter can do is to supply a patch tested aga= inst HEAD. If the patch rots because it hasn=C2=A2t been committed six mont= hs down the line it=C2=A2s not my fault. >>=20 >=20 > The problem isn't bitrot, the problem is that many patches amount to > "here's a hack that works for me," and that isn't necessarily > committable. A committer typically has to do almost as much work to > figure out whether the patch is appropriate for all users on all arches > as they would have to do to develop a fix from scratch. Even if the > submitter has mad skills and submits a perfect patch, better than what > the committer would have done from scratch, the work to analyze > everything and decide whether that's the case still has to be done. >=20 > -- Ian >=20 > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org= " > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org= "
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180601182415.BC182799>