Date: Fri, 11 Sep 2020 12:55:25 +0000 From: Glen Barber <gjb@freebsd.org> To: Ruslan Garipov <ruslanngaripov@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364891 - in head: . release release/scripts Message-ID: <20200911125525.GC61041@FreeBSD.org> In-Reply-To: <1747c711988.27b9.e2363f32305322128423a5fd7014e4c4@gmail.com> References: <202008272119.07RLJGgb043888@repo.freebsd.org> <174719d0148.27b9.e2363f32305322128423a5fd7014e4c4@gmail.com> <20200909135114.GC61041@FreeBSD.org> <1747c711988.27b9.e2363f32305322128423a5fd7014e4c4@gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, Sep 11, 2020 at 02:13:41PM +0500, Ruslan Garipov wrote: > On September 9, 2020 6:51:18 PM Glen Barber <gjb@freebsd.org> wrote: > > > On Wed, Sep 09, 2020 at 11:45:49AM +0500, Ruslan Garipov wrote: > > > On August 28, 2020 2:19:33 AM Glen Barber <gjb@FreeBSD.org> wrote: > > > > > > > Author: gjb > > > > Date: Thu Aug 27 21:19:16 2020 > > > > New Revision: 364891 > > > > URL: https://svnweb.freebsd.org/changeset/base/364891 > > > > > > > > Log: > > > > Merge the projects/release-git branch to head. > > > > This allows building 13.x from Git instead of Subversion. > > > I'm sorry for the late response (and for the bad first one I made on this > > > commit recently via Gmail web client). > > > > > > My build machine is completely offline. I provide it with fresh snapshots > > > of the source and ports tree manually -- via tarballs which I'm pulling on > > > a FreeBSD machine having Internet connection. Therefore, neither > > > "/scratch", nor the chrooted environment for me don't require Internet > > > access (I fetch distfiles for offline usage too). > > > > > > Can we somehow remove that requirement for the devel/git port? For > > > example, if one has set all three {SRC,PORTS,DOC}_UPDATE_SKIP variables, > > > then release/release.sh doesn't require devel/git to exist on the host. > > > > > > I really don't need git on my build machine (and don't need it for > > > building). > > > > > > > Can you verify if the attached patch works for your use case? You will > > need to set NOGIT=1 in your release.conf. > Partially. It doesn't require devel/git to create the initial build > environment, but it does before beginning cross-build in the > extra_chroot_setup(). > > You check there does the NOGIT have zero length. If NOGIT isn't empty, then > release.sh will ($(which git) returns nothing for me) try to install > devel/git port or package again. And NOGIT isn't empty because in this > function my release.conf was already sourced. So I had removed "not" > (``!'') on line #278, ignoring NOGIT checking, and cross-build started. > Doh! Yeah, that was a mistake - sorry about that. So as far as you are concerned, with the addition of removing the '!', it works as you expect? > It failed eventually on modifications made by r365398, but that's another > story. > > Thanks again, Glen! > Thank you for testing (and finding a silly bug)! Glen [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAl9bc70ACgkQAxRYpUeP 4pNevQ//VaPtQ0h+OCaA1yOXPpWqQ8SLdMyuyO1wE/cXpOQpz9v3o/XP22q/MA7h NVDPxvAgWOP8q3hophjadO2PnzRLVRFcP1k91rVgSscbLqL0nBG0YQF5SBH9Wk48 5Y2G/PSlTwh5KHbWBTfbYUXYeIURWyPTTvfViKzVa7PD88t3ewgLMdaGjagUGr2O 6FwRDpQYtUB9Htgt7jLe+fyEQxNdlJx38tg3GkBoBG+BRdPL7lg0+QF6/WcHQvni wlTigsRlY7r0lKdmA7fxiuNFkhBjQzmP5TtNi6iA9fZNBjdG7CxBJr7salcgrR0G 6UZt+F530n49rWGzRm1gh3zSy59dsBaPIUWTlq+Rigq9hnx9jP/lxdImBz7Bi8SF EfbcckaL/W+spL0sUJihNwyyGNuJJ2EV1UivQzMZxZdEhF6/sFMRAcNr7O0CAAlj qvrFbQdzY0YyVv7A6I+LYNSqxEWvNnmcGVYmtsn4/0W0a4KsqO3upfyeKCMJmndC Qe5dxBjXkbMJMae9htmhI1Iwim8nMM2B0yIJPLAx19lw/DNEA+XSHld4EvVqyoOj ZcI95MhiEud0zUfCfR3EuHaI6DvjlLSqBIpQutiJCG6r0jU7DkehfDiMFzCr/dIG 8KHOHDomOmayxrHkfHphKmv4IX9L9ctVaYR638Z4wr0oLCt4ddM= =qzpp -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200911125525.GC61041>