Date: Sun, 21 Aug 2022 18:10:20 -0700 From: Yuri <yuri@FreeBSD.org> To: Charlie Li <vishwin@freebsd.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 600312a9118b - main - Mk/Uses/python.mk: Add USE_PYTHON=build to support pyproject.toml based projects Message-ID: <d7eef83c-87e8-407b-0c71-2cd909777ddb@tsoft.com> In-Reply-To: <a53c15f8-3e45-a04f-f1fd-8bcf25f59c0b@freebsd.org> References: <202208212016.27LKGAYJ050818@gitrepo.freebsd.org> <cba59c50-8960-275d-8079-1c82082d32ab@freebsd.org> <4312690d-8b9e-8634-7d68-deb26213908b@tsoft.com> <a53c15f8-3e45-a04f-f1fd-8bcf25f59c0b@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Charlie, On 8/21/22 17:59, Charlie Li wrote: > Yuri wrote: >> python@ didn't say anything in the review for 14 days. >> > That doesn't mean it was approved, especially when perhaps the > maintainer-approval flag was omitted. The policy says that there is 14 days maintainer's timeout on all items with MAINTAINER: xx@FreeBSD.org except when xx==portmgr. So this is a maintainer's timeout based on the official policy. > We do not just add stuff into Uses/*.mk files without proper design > and qualification. Specifically, Uses/python.mk is fragile as it is, > with USE_PYTHON=distutils for instance. This needs time and effort to > germinate. It wasn't "just added". The maintainer had a chance to voice his concerns, and he didn't. > There were open questions in the discussion, which are intentionally > not specific because the overall design is not currently firm. It's impossible to do anything about non-specific questions. It was a window to discuss any specific improvements and nobody voiced anything specific. Could you please formulate a specific objection. Do you run some command that fails that shouldn't fail? BTW, I received 2 private e-mails from committers with unofficial thumbs ups. So it was actually reviewed. Regards, Yuri
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d7eef83c-87e8-407b-0c71-2cd909777ddb>