Date: Sun, 12 Apr 2015 16:26:40 +0200 From: Rodrigo OSORIO <rodrigo@freebsd.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r383869 - in head/x11/tilda: . files Message-ID: <552A80A0.40706@freebsd.org> In-Reply-To: <20150412141020.GA40906@FreeBSD.org> References: <201504121406.t3CE6q8f015308@svn.freebsd.org> <20150412141020.GA40906@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/12/15 16:10, Alexey Dokuchaev wrote: > On Sun, Apr 12, 2015 at 02:06:52PM +0000, Rodrigo Osorio wrote: >> New Revision: 383869 >> URL: https://svnweb.freebsd.org/changeset/ports/383869 >> >> Log: >> Upgrade tilda to latest stable release 1.2.2 >> Fix/Rework build >> >> PR: 198763 >> Submitted by: rodrigo (maintainer) > > I don't quite get it: you've submitted a PR as maintainer, only to commit > it yourself as a comitter? Or it should read "approved by" instead? > > ./danfe > Hi danfe, Someone sent me a PR to request an update, I did the job and submit the changes with the PR number PR. I put my name as submitter because as said in the committer handbook : "Submitted by: The name and e-mail address of the person that submitted the fix; for developers, just the username on the FreeBSD cluster.". And I did the fix. Regards, - rodrigo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?552A80A0.40706>