Date: Tue, 26 Sep 2017 11:03:27 +0000 From: "eugen_grosbein.net (Eugene Grosbein)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D12457: Complete INADDR_HASH lock protection Message-ID: <606e99cbfff1346e8b7d3cea10741544@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-em3ftishzefmzreicm43-req@FreeBSD.org> References: <differential-rev-PHID-DREV-em3ftishzefmzreicm43-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
eugen_grosbein.net marked an inline comment as done. eugen_grosbein.net added inline comments. INLINE COMMENTS > mav wrote in in_mcast.c:1383 > Do I miss some other protection means or this and few below places just scream about possible races due to missing interface pointer pulled out of the lock without taking reference? > > I suspect INADDR_TO_IFP KPI is not safe now in general. Yes, it does. I just want to fix that what's easy to fix to start. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D12457 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: eugen_grosbein.net, ae, avg, mav, rwatson Cc: bz, imp, freebsd-net-list
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?606e99cbfff1346e8b7d3cea10741544>