Date: Fri, 14 Sep 2001 09:35:53 GMT From: "news" <news@postboks.org> To: security@FreeBSD.ORG Subject: Re: netbsd vulnerabilities Message-ID: <20010914093553.22895.qmail@easyisp.org>
next in thread | raw e-mail | index | archive | help
anyone know when there will be anything official out there for this problem ? with regards rasmus fauske > "Andrew R. Reiter" <arr@watson.org> wrote: > > The attached code fixes the semop bug which is specified in the recent > > NetBSD security announcement. I'm not positive about hte naming scheme > > wanted by all in terms of: size_t vs. unsigned int vs. unsigned. I made > > it u_int b/c i saw in sysproto.h that there seemed to be more u_int's > > instead of size_t's :-) Great logic.> > I think semop_args.nsops should be u_int (like you made it) because > that's how it's listed in syscalls.master. It should match the (SYSV) spec, whatever that says. syscalls.master is rarely correct.> > --- sys/sem.h.orig Sat Sep 8 03:21:08 2001 > > +++ sys/sem.h Sat Sep 8 03:21:27 2001> > @@ -101,7 +101,7 @@ > > int semsys __P((int, ...));> > int semctl __P((int, int, int, ...)); > > int semget __P((key_t, int, int)); > > -int semop __P((int, struct sembuf *,unsigned)); > > +int semop __P((int, struct sembuf *, u_int));> > I don't see the point of this, either, except to break consistency > with the manual page. `u_int' is the same as `unsigned'. This also fixes a style bug (missing space after comma) and takes us further from removing dependencies on <sys/types.h>. Anyway, this has nothing to do with the bug (unless the correct type is not unsignedint). > The other changes look pretty good. Attached is the corresponding > patch to -current. If nobody sees anything wrong in about a day, I'll > commit this and MFC it after the RE's approval.OK.Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-security" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-security" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010914093553.22895.qmail>