Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 10 Jul 2018 06:42:12 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 229663] src/sys/netinet/libalias/alias_irc.c:101: poor error checking
Message-ID:  <bug-229663-227@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229663

            Bug ID: 229663
           Summary: src/sys/netinet/libalias/alias_irc.c:101: poor error
                    checking
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: bugs@FreeBSD.org
          Reporter: dcb314@hotmail.com

src/sys/netinet/libalias/alias_irc.c:101]: (style) Same expression on both
sides of '||'.

Source code is

        if (ah->dport =3D=3D NULL || ah->dport =3D=3D NULL || ah->lnk =3D=
=3D NULL ||
            ah->maxpktsize =3D=3D 0)
                return (-1);

Maybe better code

        if (ah->sport =3D=3D NULL || ah->dport =3D=3D NULL || ah->lnk =3D=
=3D NULL ||
            ah->maxpktsize =3D=3D 0)
                return (-1);

--=20
You are receiving this mail because:
You are the assignee for the bug.=

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-229663-227>