Date: Mon, 27 Mar 2017 10:04:39 +0300 From: "Andriy Voskoboinyk" <avos@freebsd.org> To: "Hartmann, O." <ohartmann@walstatt.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r315981 - head/sys/dev/iwn Message-ID: <op.yxqy92u54dikkl@thinkpad-x220> In-Reply-To: <20170326164309.759fc5b9@hermann> References: <201703260910.v2Q9A26Z081833@repo.freebsd.org> <20170326164309.759fc5b9@hermann>
next in thread | previous in thread | raw e-mail | index | archive | help
Sun, 26 Mar 2017 17:43:18 +0300 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Hartmann, O. = <ohartmann@walstatt.org>: > On Sun, 26 Mar 2017 09:10:02 +0000 (UTC) > Andriy Voskoboinyk <avos@FreeBSD.org> wrote: > >> Author: avos >> Date: Sun Mar 26 09:10:01 2017 >> New Revision: 315981 >> URL: https://svnweb.freebsd.org/changeset/base/315981 >> >> Log: >> iwn: omit unneeded bus_dmamap_sync() calls when compiled without >> 'options IWN_DEBUG' >> >> Modified: >> head/sys/dev/iwn/if_iwn.c >> >> Modified: head/sys/dev/iwn/if_iwn.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D >> --- head/sys/dev/iwn/if_iwn.c Sun Mar 26 08:54:08 2017 >> (r315980) +++ head/sys/dev/iwn/if_iwn.c Sun Mar 26 09:10:01 >> 2017 (r315981) @@ -3944,6 +3944,7 @@ iwn_notif_intr(struct >> iwn_softc *sc) sc->errptr =3D le32toh(uc->errptr); >> break; >> } >> +#ifdef IWN_DEBUG >> case IWN_STATE_CHANGED: >> { >> /* >> @@ -3953,27 +3954,26 @@ iwn_notif_intr(struct iwn_softc *sc) >> */ >> bus_dmamap_sync(sc->rxq.data_dmat, data->map, >> BUS_DMASYNC_POSTREAD); >> -#ifdef IWN_DEBUG >> + >> uint32_t *status =3D (uint32_t *)(desc + 1); >> DPRINTF(sc, IWN_DEBUG_INTR | IWN_DEBUG_STATE, >> "state changed to %x\n", >> le32toh(*status)); >> -#endif >> break; >> } >> case IWN_START_SCAN: >> { >> bus_dmamap_sync(sc->rxq.data_dmat, data->map, >> BUS_DMASYNC_POSTREAD); >> -#ifdef IWN_DEBUG >> + >> struct iwn_start_scan *scan =3D >> (struct iwn_start_scan *)(desc + 1); >> DPRINTF(sc, IWN_DEBUG_ANY, >> "%s: scanning channel %d status %x\n", >> __func__, scan->chan, >> le32toh(scan->status)); -#endif >> break; >> } >> +#endif >> case IWN_STOP_SCAN: >> { >> bus_dmamap_sync(sc->rxq.data_dmat, data->map, >> _______________________________________________ >> svn-src-head@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to >> "svn-src-head-unsubscribe@freebsd.org" > > It seems when iwm is configured in a kernel without debugging enabled,= > builkernel failsas shown below: > > > > > [...] > -------------------------------------------------------------- >>>> stage 3.1: building everything > -------------------------------------------------------------- > cd /usr/obj/usr/src/sys/HERMANN; COMPILER_VERSION=3D40000 > COMPILER_TYPE=3Dclang COMPILER_FREEBSD_VERSION=3D1200006 > MAKEOBJDIRPREFIX=3D/usr/obj MACHINE_ARCH=3Damd64 MACHINE=3Damd64 > CPUTYPE=3Dnative BUILD_TOOLS_META=3D.NOMETA_CMP > GROFF_BIN_PATH=3D/usr/obj/usr/src/tmp/legacy/usr/bin > GROFF_FONT_PATH=3D/usr/obj/usr/src/tmp/legacy/usr/share/groff_font > GROFF_TMAC_PATH=3D/usr/obj/usr/src/tmp/legacy/usr/share/tmac CC=3D"cc > -target x86_64-unknown-freebsd12.0 --sysroot=3D/usr/obj/usr/src/tmp > -B/usr/obj/usr/src/tmp/usr/bin" CXX=3D"c++ -target > x86_64-unknown-freebsd12.0 --sysroot=3D/usr/obj/usr/src/tmp > -B/usr/obj/usr/src/tmp/usr/bin" CPP=3D"cpp -target > x86_64-unknown-freebsd12.0 --sysroot=3D/usr/obj/usr/src/tmp > -B/usr/obj/usr/src/tmp/usr/bin" AS=3D"as" AR=3D"ar" LD=3D"ld" LLVM_LI= NK=3D"" > NM=3Dnm OBJCOPY=3D"objcopy" RANLIB=3Dranlib STRINGS=3D SIZE=3D"size"= > INSTALL=3D"sh /usr/src/tools/install.sh" > PATH=3D/usr/obj/usr/src/tmp/legacy/usr/sbin:/usr/obj/usr/src/tmp/legac= y/usr/bin:/usr/obj/usr/src/tmp/legacy/bin:/usr/obj/usr/src/tmp/usr/sbin:= /usr/obj/usr/src/tmp/usr/bin:/sbin:/bin:/usr/sbin:/usr/bin > make -m /usr/src/share/mk KERNEL=3Dkernel all -DNO_MODULES_OBJ > Building /usr/obj/usr/src/sys/HERMANN/if_iwm_scan.o = > /usr/src/sys/dev/iwm/if_iwm_scan.c:224:12: > error: unused variable 'aborted' [-Werror,-Wunused-variable] boolean_t= > aborted =3D (scan_notif->status =3D=3D IWM_SCAN_OFFLOAD_ABORTED); > ^ /usr/src/sys/dev/iwm/if_iwm_scan.c:251:11: error: unused variable > 'uid' [-Werror,-Wunused-variable] uint32_t uid =3D le32toh(notif->uid)= ; Fixed in r316010.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.yxqy92u54dikkl>