Date: Wed, 28 Nov 2018 04:44:44 +0000 From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 233561] converters/py-rencode: Fails to configure if cython is installed Message-ID: <bug-233561-21822-SbZqnHUR1g@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-233561-21822@https.bugs.freebsd.org/bugzilla/> References: <bug-233561-21822@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233561 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|converters/py-rencode: |converters/py-rencode: |configure fails if cython |Fails to configure if |installed |cython is installed CC| |python@FreeBSD.org, | |sunpoet@FreeBSD.org Assignee|python@FreeBSD.org |koobs@FreeBSD.org Status|New |Open --- Comment #1 from Kubilay Kocak <koobs@FreeBSD.org> --- Investigation summary: 1) ports r482774 removed USE_PYTHON=3Dcython (inadvertently, due to (2), or because the package successfully built without cython) 2) upstream setup.py does not declare cython as a dependency 3) upstream dev-requirements.txt does declare it as a dependency (noop for setuptools/pip based installs as they use setup.py:*_requires) 4) upstream setup.py conditionally (when importable/found) uses Cython (.pyx file) for the build, falling back to a setuptools build_ext (.c file) build 5) The 1.0.6 PyPI sdist (only) ships with a .c file 6) Upstream commit 5c928f14567fabc9efb8bbb8ac5e0eef03c61541 via issue #25 [= 1] adds a pyx file (not yet released). 7) setup.py declares 'sdist requires cython module to generate c' file, appearing to indicate it (cython) is a development dependency, prior to, and for producing, the relevant source distribution (which we use). In my opinion, a cython build (and the dependency on cython) it not necessa= ry (particularly given (5) and (7)), even after #25 is released and the conditional code to build with cython should not be included in setup.py, at least not as a default case, or without an explicit request by the user to = use cython, as an optional build method, for sdist consumers (most downstream packagers, and setuptools/pip users) [1] https://github.com/aresch/rencode/commit/5c928f14567fabc9efb8bbb8ac5e0eef03= c61541 [2] https://github.com/aresch/rencode/pull/25 --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233561-21822-SbZqnHUR1g>