Date: Thu, 11 Dec 2008 13:38:04 -0800 From: "Kip Macy" <kmacy@freebsd.org> To: "Bruce M. Simpson" <bms@freebsd.org> Cc: Qing Li <qingli@freebsd.org>, current@freebsd.org, freebsd-net@freebsd.org Subject: Re: last call for L2/L3 rewrite code review Message-ID: <3c1674c90812111338p69c33bd5sa26315cba4981011@mail.gmail.com> In-Reply-To: <49415977.6010307@FreeBSD.org> References: <200812100740.mBA7eqjO034924@freefall.freebsd.org> <49415977.6010307@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I think that you're request to not monopolize the AF_INET slot is reasonable. Do you intend to merge bms_netdev before 8 branches (I'm guessing this coming summer)? Cheers, Kip On Thu, Dec 11, 2008 at 10:18 AM, Bruce M. Simpson <bms@freebsd.org> wrote: > Hi, > > Just skimming this I notice it uses the if_afdata[AF_INET] pointer purely > for lltbl purposes; this clashes with the IGMPv3 code drop. > > Please look in the bms_netdev branch, where I introduce a 'struct ip_ifinfo' > to make more general use of that slot. IGMPv3 needs to store per-interface > state for AF_INET, so this slot really needs to be shared with other AF_INET > stuff. > > Looks like it needs to be updated for VIMAGE also, hopefully others more > familiar with this can help -- I am busy enough with non-programming > activity as it is to get up to speed on this, although I have at least > managed to print Julian's write-up... > > Other than that, it looks like a much needed improvement and we are all very > grateful for our work on this. > > thanks > BMS > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > -- If we desire respect for the law, we must first make the law respectable. - Louis D. Brandeis
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3c1674c90812111338p69c33bd5sa26315cba4981011>