Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Jun 2020 04:03:32 +0800
From:      Li-Wen Hsu <lwhsu@freebsd.org>
To:        Mateusz Piotrowski <0mp@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>,  svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   Re: svn commit: r362687 - in stable/12/usr.bin/sed: . tests
Message-ID:  <CAKBkRUyJxU7pFTG2pVWanBOUbD8zAOnC_8TUzFVEBx8fedxjVA@mail.gmail.com>
In-Reply-To: <202006271427.05RERbw3073838@repo.freebsd.org>
References:  <202006271427.05RERbw3073838@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 27, 2020 at 10:27 PM Mateusz Piotrowski <0mp@freebsd.org> wrote:
>
> Author: 0mp (doc,ports committer)
> Date: Sat Jun 27 14:27:37 2020
> New Revision: 362687
> URL: https://svnweb.freebsd.org/changeset/base/362687
>
> Log:
>   MFC 362017, 362039, 362071:
>
>   Read commands from stdin when -f - is passed to sed(1)
>
>   This patch teaches sed to interpret a "-" in a special way when given
>   as an argument to the -f flag.
>
>   This behavior is also present in GNU sed.
>
>   PR:           244872
>   Tested by:    antoine (exp-run)
>   Reviewed by:  pfg, tobik (older version)
>   Approved by:  pfg (src)
>   Relnotes:     yes
>   Differential Revision:        https://reviews.freebsd.org/D24079
>
>   Remove duplicate lines from sed tests
>
>   Reported by:  yuripv
>   Approved by:  pfg (src)
>
>   Remove some more duplicate test cases I accidentally committed
>
>   Reported by:  markj, yuripv

Hi,

I think this MFC and for 11's might have some issues. The test cases
under usr.bin.sed.sed2_test cannot be listed thus cannot be executed:

https://ci.freebsd.org/job/FreeBSD-stable-12-i386-test/2458/testReport/junit/usr.bin.sed/sed2_test/
https://ci.freebsd.org/job/FreeBSD-stable-11-amd64-test/5150/testReport/junit/usr.bin.sed/sed2_test/

This is how they should look like:

https://ci.freebsd.org/job/FreeBSD-head-amd64-test/15686/testReport/usr.bin.sed/sed2_test/

You can try with `cd /usr/tests/usr.bin/sed && kyua list sed2_test`.
Please check if the merged sed2_test.sh needs adjusting.

Thanks,
Li-Wen



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUyJxU7pFTG2pVWanBOUbD8zAOnC_8TUzFVEBx8fedxjVA>