Date: Mon, 1 Sep 2003 09:08:18 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: deischen@FreeBSD.org Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/gcc/config freebsd-spec.h Message-ID: <20030901160817.GA64187@dragon.nuxi.com> In-Reply-To: <Pine.GSO.4.10.10309010150280.12380-100000@pcnet5.pcnet.com> References: <20030901054538.GA93247@dragon.nuxi.com> <Pine.GSO.4.10.10309010150280.12380-100000@pcnet5.pcnet.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 01, 2003 at 02:08:58AM -0400, Daniel Eischen wrote:
> > > > Please back this out.
Thank you for backing this out.
> > For one, don't forget people use the GCC ports and the stock sources from
> > the FSF -- we don't need the system compiler to be the old man out. If
> > you really want to de-support "-pthread" there are two ways to go about
> > it. (1) starting with some GCC version, (2) starting with targeting a
> > particular FreeBSD version. For instance we could either say that GCC
> > 3.4 does not accept "-pthread" for any FreeBSD target. Or we could say
> > that GCC targeting RELENG_5 does not accept "-pthread". It should be
> > clear which is being chosen and the repercussions.
>
> RELENG_5 should not support it. We need to get rid of
> it ASAP so we can work on getting our ports free of it
> and making them work with other thread libraries.
>
> How do we accomplish this quickly?
Sounds like you want a policy that:
"-pthread" should not be supported when targeting FreeBSD 5.{2-9}
using FSF GCC 3.3.2 (and 3.3.1 in /usr/src).
You would also like to not support "-pthread" when targeting FreeBSD 4.x.
I'm not convinced that we really can remove it there. Also that will
make FSF GCC 3.3.2 not accept the same options that the system FreeBSD
4.x compiler does. Can we live with tolerating "-pthread" when targeting
FreeBSD 4.x by any version of FSF GCC?
If so, an acceptable diff would be to only change the FBSD_LIB_SPEC w/in
the "#if __FreeBSD_version >= 500016" block. Turning "-pthread" into a
NOP + warning would be nice, but the error output code you replaced the
entire FBSD_LIB_SPEC with would be OK too I guess. The comment
addressing "At __FreeBSD_version 500016 and later,..." should be updated.
Can you commit such a change? I'll get it into the right FSF GCC
person's hands for GCC 3.3.2.
--
-- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030901160817.GA64187>