Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 2 Feb 2023 08:10:03 GMT
From:      =?utf-8?Q?Stefan=20E=C3=9Fer?= <se@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: f7e5465cb597 - main - Revert "sys/kbio.h: support Unicode key codes in vt keymap files"
Message-ID:  <202302020810.3128A3Ln008061@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by se:

URL: https://cgit.FreeBSD.org/src/commit/?id=f7e5465cb597d213ddff93e957d16f84cdc26951

commit f7e5465cb597d213ddff93e957d16f84cdc26951
Author:     Stefan Eßer <se@FreeBSD.org>
AuthorDate: 2023-02-02 08:05:43 +0000
Commit:     Stefan Eßer <se@FreeBSD.org>
CommitDate: 2023-02-02 08:05:43 +0000

    Revert "sys/kbio.h: support Unicode key codes in vt keymap files"
    
    It has been pointed out, that this change causes ABI breakage for
    [GP]IO_DEADKEYMAP. I'll create a review on phabricator.
    
    Since the 8 bit limit on keycodes causes issues for certain keymaps,
    a fix should be committed in time to allow a MFC to 13.2.
    
    This reverts commit 1e0853ee84031e4131a0b8cc8737696f199d3d4c.
    
    Reported by:        Jessica Clarke
---
 sys/sys/kbio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/sys/kbio.h b/sys/sys/kbio.h
index b0779f5ed114..7f17bda76c51 100644
--- a/sys/sys/kbio.h
+++ b/sys/sys/kbio.h
@@ -200,7 +200,7 @@ typedef struct okeymap okeymap_t;
 
 struct acc_t {
 	u_char		accchar;
-	u_short		map[NUM_ACCENTCHARS][2];
+	u_char		map[NUM_ACCENTCHARS][2];
 };
 
 struct accentmap {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202302020810.3128A3Ln008061>