Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 10 Jul 2023 09:00:54 -0700
From:      John Baldwin <jhb@FreeBSD.org>
To:        Warner Losh <imp@bsdimp.com>, Alexey Dokuchaev <danfe@freebsd.org>
Cc:        Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 29cbe944e928 - main - CONTRIBUTING.md: minor changes
Message-ID:  <1e07dc3f-071c-bd8d-3f15-4aaee60582f6@FreeBSD.org>
In-Reply-To: <CANCZdfq9o8qA%2B=CxOW1y5LybDqW0XvdNiFhcY_CjDEvVZf9g_w@mail.gmail.com>
References:  <202307072123.367LNZ4J060993@gitrepo.freebsd.org> <ZKj_DU6rzJunuHLb@FreeBSD.org> <CANCZdfq9o8qA%2B=CxOW1y5LybDqW0XvdNiFhcY_CjDEvVZf9g_w@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 7/9/23 8:06 PM, Warner Losh wrote:
> On Sat, Jul 8, 2023 at 12:15 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:
> 
>> On Fri, Jul 07, 2023 at 09:23:35PM +0000, Warner Losh wrote:
>>> commit 29cbe944e9287c2e61928c456512d3990aaffdaa
>>>
>>>    CONTRIBUTING.md: minor changes
>>>
>>>    - Misspelled GitHub
>>>    - angle bracket not escaped correctly
>>>    - Double white spaces
>>
>> You've removed them, while they are typically used after full stops
>> as texts render better with them unless you're using proportional
>> font.
>>
> 
> It's the modern way....   but  WuerfelDev also had a commit that backed
> that part out that I didn't fold in...
> I'm still torn since I see so many conflicting things about it :(
> 
> I'm leaning towards putting them back.

FWIW, I still use monospace fonts for code and thus still use double spaces
for the reason Alexey stated.  Reading code in proportional fonts (where
spacing is naturally wider at sentence breaks) is not really viable with
style(9) which mixes tabs with spaces for indentation.

-- 
John Baldwin




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1e07dc3f-071c-bd8d-3f15-4aaee60582f6>