Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Sep 2014 00:41:50 +0400
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        "Alexander V. Chernikov" <melifaro@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r272211 - head/sys/net
Message-ID:  <20140927204150.GS884@FreeBSD.org>
In-Reply-To: <201409271357.s8RDvmTC072149@svn.freebsd.org>
References:  <201409271357.s8RDvmTC072149@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Sep 27, 2014 at 01:57:48PM +0000, Alexander V. Chernikov wrote:
A> Author: melifaro
A> Date: Sat Sep 27 13:57:48 2014
A> New Revision: 272211
A> URL: http://svnweb.freebsd.org/changeset/base/272211
A> 
A> Log:
A>   Use underlying ports counters to get lagg statistics instead of
A>   per-packet accounting.
A>   This introduce user-visible changes like aggregating error counters.
A>   
A>   Reviewed by:	asomers (prev.version), glebius
A>   CR:		D781
A>   MFC after:	2 weeks
A>   Sponsored by:	Yandex LLC

Btw, lagg_transmit() still contains two ifp->if_oerrors++. Can you
look at them?

It seems to me that the second one would account an error already
accounted by port interface.

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140927204150.GS884>