Date: Thu, 22 Feb 2024 17:15:48 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Warner Losh <imp@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: dcb621efd664 - main - loader: Mark BEARSSL broken on powerpc Message-ID: <7777BCB9-E648-46A5-894F-982ED906A678@freebsd.org> In-Reply-To: <202402221708.41MH8rkv083618@gitrepo.freebsd.org> References: <202402221708.41MH8rkv083618@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22 Feb 2024, at 17:08, Warner Losh <imp@FreeBSD.org> wrote: > > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=dcb621efd6645d3f3a227c8c9113cc717e903389 > > commit dcb621efd6645d3f3a227c8c9113cc717e903389 > Author: Warner Losh <imp@FreeBSD.org> > AuthorDate: 2024-02-22 17:05:40 +0000 > Commit: Warner Losh <imp@FreeBSD.org> > CommitDate: 2024-02-22 17:08:12 +0000 > > loader: Mark BEARSSL broken on powerpc > > When BEARSSL is enabled, we pull in libsecureboot, which has EFI > dependencies which don't exist on powerpc. This needs to be detangled, > but until then mark it as broken. > > Sponsored by: Netflix > --- > share/mk/src.opts.mk | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/share/mk/src.opts.mk b/share/mk/src.opts.mk > index e154fbd4059d..3eec831db2cc 100644 > --- a/share/mk/src.opts.mk > +++ b/share/mk/src.opts.mk > @@ -313,6 +313,9 @@ BROKEN_OPTIONS+=LIB32 > .if ${__T:Mpowerpc*} || ${__T} == "i386" > BROKEN_OPTIONS+=EFI > .endif > +# Bad coupling for libsecure stuff with bearssl and efi, so broken on EFI > +.if ${__T:Mpowerpc*} > +BROKEN_OPTIONS+=BEARSSL # bearssl brings in secure efi stuff xxx > # OFW is only for powerpc, exclude others Missing .endif (maybe you initially had it in the block below?) Jess > .if ${__T:Mpowerpc*} == "" > BROKEN_OPTIONS+=LOADER_OFW
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7777BCB9-E648-46A5-894F-982ED906A678>