Date: Fri, 22 Apr 2016 00:55:00 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Garrett Cooper <ngie@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298462 - head/contrib/bsnmp/snmp_mibII Message-ID: <3CEC0CBF-09FC-430E-B92F-E554CE66648B@gmail.com> In-Reply-To: <201604220751.u3M7pcUO033612@repo.freebsd.org> References: <201604220751.u3M7pcUO033612@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 22, 2016, at 00:51, Garrett Cooper <ngie@FreeBSD.org> wrote: > > Author: ngie > Date: Fri Apr 22 07:51:38 2016 > New Revision: 298462 > URL: https://svnweb.freebsd.org/changeset/base/298462 > > Log: > Return `ret` in op_ifentry(..) to mute a -Wunused-but-set-variable warning > > This will also now detect error conditions with > value->var.subs[sub - 1] == LEAF_ifPhysAddress where `string_get(..)` > could fail if iifp->physaddr and/or iifp->physaddrlen were deemed > invalid. > > MFC after: 2 weeks > CID: 1006551 > Reported by: Coverity, gcc > Sponsored by: EMC / Isilon Storage Division I pulled up the wrong CID. Coverity didn’t actually complain about this — just gcc. Thanks, -Ngie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3CEC0CBF-09FC-430E-B92F-E554CE66648B>