Date: Mon, 14 Apr 2014 22:58:37 +0200 From: Jakub Klama <jakub.klama@uj.edu.pl> To: freebsd-arm@freebsd.org Subject: Re: [RFC] Refactored interrupt handling on ARM Message-ID: <f2bebfa812ecb70f423b6be4779b217b@uj.edu.pl> In-Reply-To: <534C0F48.2090302@freebsd.org> References: <3e7f866f4bc774975ae3c85e0df78ec2@uj.edu.pl> <53418D13.7030107@freebsd.org> <534C0F48.2090302@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 14 Apr 2014 09:39:36 -0700, Nathan Whitehorn wrote: > This is really nice! One quick question: why have you made > FDT_MAP_IRQ() a public interface? Shouldn't calling the function it > maps to just be a private implementation detail in nexus? > -Nathan Well, FDT_MAP_IRQ() existed before my changes and was public. It just returned pin and discarded the node parameter: #define FDT_MAP_IRQ(node, pin) (pin) so I left it as is and changed the implementation to route IRQ to parent IC. Jakub
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f2bebfa812ecb70f423b6be4779b217b>