Date: Sat, 19 May 2012 19:34:52 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Andriy Gapon <avg@freebsd.org> Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-8@FreeBSD.org Subject: Re: svn commit: r235650 - stable/8/usr.sbin/mfiutil Message-ID: <3CC44A84-4FF8-4850-B38B-DF0A3C26EAC1@FreeBSD.org> In-Reply-To: <4FB7ECFC.2020509@FreeBSD.org> References: <201205191432.q4JEWle6027225@svn.freebsd.org> <4FB7ECFC.2020509@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
On 19. May 2012, at 18:57 , Andriy Gapon wrote: > on 19/05/2012 17:32 Bjoern A. Zeeb said the following: >> Author: bz >> Date: Sat May 19 14:32:47 2012 >> New Revision: 235650 >> URL: http://svn.freebsd.org/changeset/base/235650 >> >> Log: >> MFC r233713: >> >> Remove the magic mfi_array is 288 bytes and just use the >> sizeof the array since it is not 288 bytes. >> >> Change reporting of a "SYSTEM" disk to "JBOD" to match >> LSI MegaCli and firmware reporting. >> >> This means that mfiutil command to "create jbod" is now a >> little confusing since a RAID per drive is not really what >> LSI defines JBOD to be. This should be fixed in the future >> and support added to really create LSI JBOD and enable that >> feature on cards that support it. >> >> To unbreak the build after: r235625 (?) .. >> @@ -211,9 +211,8 @@ clear_config(int ac, char **av) >> } >> MFI_COMMAND(top, clear, clear_config); >> >> -#define MFI_ARRAY_SIZE 288 >> -#define MAX_DRIVES_PER_ARRAY \ >> - ((MFI_ARRAY_SIZE - sizeof(struct mfi_array)) / 8) >> +#define MAX_DRIVES_PER_ARRAY MFI_MAX_ROW_SIZE >> +#define MFI_ARRAY_SIZE sizeof(struct mfi_array) > > A small nit: previously MFI_ARRAY_SIZE wasn't used for anything except > MAX_DRIVES_PER_ARRAY, now it's not used for anything. Whatever else needs to be fixed in HEAD or MFCed to stable I don't know; see the last line of my commit message and talk to the other suspects like jhb, sbruno, ambrisko, emaste.... -- Bjoern A. Zeeb You have to have visions! It does not matter how good you are. It matters what good you do!home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3CC44A84-4FF8-4850-B38B-DF0A3C26EAC1>