Date: Fri, 26 Jun 2026 23:03:16 +0000 From: Siva Mahadevan <siva@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 5b8c28adb829 - main - ping/tests: expect bell chars from stderr after initial status Message-ID: <6a3f0534.34ab3.7098834f@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by siva: URL: https://cgit.FreeBSD.org/src/commit/?id=5b8c28adb829b50fb8ac065637fa99f717858bab commit 5b8c28adb829b50fb8ac065637fa99f717858bab Author: Siva Mahadevan <siva@FreeBSD.org> AuthorDate: 2026-06-26 12:22:57 +0000 Commit: Siva Mahadevan <siva@FreeBSD.org> CommitDate: 2026-06-26 22:46:09 +0000 ping/tests: expect bell chars from stderr after initial status After 141bb85798 and 8bda488114f3, ping(8) first writes and flushes the initial status to stdout, then writes notification bell characters to stderr. This patch corrects the expected order of the output to stdout and stderr. This is a temporary fix; the test should be rewritten to separate the output streams and run expectations on each individually. Reviewed by: des MFC after: 3 days Sponsored by: The FreeBSD Foundation --- sbin/ping/tests/test_ping.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sbin/ping/tests/test_ping.py b/sbin/ping/tests/test_ping.py index fdf9c875329c..88164c2ab816 100644 --- a/sbin/ping/tests/test_ping.py +++ b/sbin/ping/tests/test_ping.py @@ -431,8 +431,8 @@ round-trip min/avg/max/stddev = /// ms "args": "ping -A -c3 192.0.2.2", "returncode": 2, "stdout": """\ -\x07\x07PING 192.0.2.2 (192.0.2.2): 56 data bytes - +PING 192.0.2.2 (192.0.2.2): 56 data bytes +\x07\x07 --- 192.0.2.2 ping statistics --- 3 packets transmitted, 0 packets received, 100.0% packet loss """, @@ -463,8 +463,8 @@ round-trip min/avg/max/stddev = /// ms "args": "ping -A -c3 2001:db8::2", "returncode": 2, "stdout": """\ -\x07\x07PING(56=40+8+8 bytes) 2001:db8::1 --> 2001:db8::2 - +PING(56=40+8+8 bytes) 2001:db8::1 --> 2001:db8::2 +\x07\x07 --- 2001:db8::2 ping statistics --- 3 packets transmitted, 0 packets received, 100.0% packet loss """,home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a3f0534.34ab3.7098834f>