Date: Fri, 24 Jan 1997 11:24:55 -0800 (PST) From: "Jordan K. Hubbard" <jkh> To: CVS-committers, cvs-all, cvs-user Subject: cvs commit: src/release/sysinstall cdrom.c dist.c floppy.c globals.c install.c media.c menus.c nfs.c options.c package.c sysinstall.h system.c user.c Message-ID: <199701241924.LAA14392@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
jkh 97/01/24 11:24:55
Modified: release/sysinstall cdrom.c dist.c floppy.c globals.c
install.c media.c menus.c nfs.c options.c
package.c sysinstall.h system.c user.c
Log:
OK, I've got two ideas to file in the "really seemed like a good idea
at the time, but on further reflection..." bucket with these changes.
1. Checking the media before frobbing the disks was a fine idea, and
I wish it could have worked, but that leads to a rather difficult
situation when you need to mount the media someplace and you're about
to:
a) Chroot away from your present root.
b) Newfs the root to be.
You're basically screwed since there's no place to stick the mount
point where it will be found following the newfs/chroot (and eliminating
the chroot in favor of just using the "root bias" feature would work
great for the distributions but not the pkg_add calls done by the
package installer).
2. Automatic timeout handling. I don't know why, but alarm() frequently
returns no residual even when the alarm didn't go off, which defies
the man page but hey, since when was that so unusual? Take out timeouts
but retain the code which temporarily replaces the SIGINT handler in
favor of a more media-specific handler. This way, at least, if it's hanging
you can at least whap it. I think the timeout code would have been losing
over *really slow* links anyway, so it's probably best that it go.
This should fix NFS, tape & CDROM installs again (serves me right for getting
complacent and using just the FTP installs in my testing).
Revision Changes Path
1.36 +2 -2 src/release/sysinstall/cdrom.c
1.96 +32 -27 src/release/sysinstall/dist.c
1.22 +2 -2 src/release/sysinstall/floppy.c
1.17 +0 -2 src/release/sysinstall/globals.c
1.163 +16 -56 src/release/sysinstall/install.c
1.77 +25 -27 src/release/sysinstall/media.c
1.110 +6 -2 src/release/sysinstall/menus.c
1.17 +3 -3 src/release/sysinstall/nfs.c
1.52 +1 -1 src/release/sysinstall/options.c
1.53 +0 -1 src/release/sysinstall/package.c
1.110 +0 -3 src/release/sysinstall/sysinstall.h
1.75 +0 -26 src/release/sysinstall/system.c
1.10 +0 -4 src/release/sysinstall/user.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199701241924.LAA14392>