Date: Sun, 16 Sep 2012 00:25:07 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r304300 - in head/java/jamvm: . files Message-ID: <20120915222507.GB13414@ithaqua.etoilebsd.net> In-Reply-To: <201209142202.q8EM2ABa017821@svn.freebsd.org> References: <201209142202.q8EM2ABa017821@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--EuxKj2iCbKjpUGkD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 14, 2012 at 10:02:10PM +0000, Jung-uk Kim wrote: > Author: jkim > Date: Fri Sep 14 22:02:09 2012 > New Revision: 304300 > URL: http://svn.freebsd.org/changeset/ports/304300 >=20 > Log: > - Update to 1.5.4. > - Reset maintainer to java. > - Convert to optionsNG and add license. > - Unbreak sparc64. > =20 > PR: ports/164941 (partial) >=20 [...] > +FFI_CFLAGS!=3D pkgconf libffi --cflags > +FFI_LDFLAGS!=3D pkgconf libffi --libs-only-L This is not a good idea as is because it break make index that way: "Makefile", line 34: warning: "pkgconf libffi --cflags" returned non-zero s= tatus "Makefile", line 35: warning: "pkgconf libffi --libs-only-L" returned non-z= ero status if run on a system without pkgconf installed to fix this part adding "|| :" at the end of the command might be a good id= ea. I suspect (untested) that it may also make the ports fail to build in a particular situation which is, on a system not having yet pkgconf you try to install jamvm. FFI_CFLAGS and FFI_LDFLAGS might in that case be expanded to nothing before pkgconf is installed as a dependency. The right fix should be then imho to patch the jamvm build system to invoke pkgconf libffi itself. regards, Bapt --EuxKj2iCbKjpUGkD Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlBVAEMACgkQ8kTtMUmk6EzHnACgqsStxg2vcHEzdeWSphvd3Na9 V00AoKTCESx7ccCCwDCpGFqL/eJPCEB9 =j65j -----END PGP SIGNATURE----- --EuxKj2iCbKjpUGkD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120915222507.GB13414>