Date: Fri, 9 Apr 2004 18:35:52 +0300 From: Ruslan Ermilov <ru@FreeBSD.ORG> To: Maxime Henrion <mux@FreeBSD.ORG> Cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/mt mt.c Message-ID: <20040409153552.GC1992@ip.net.ua> In-Reply-To: <20040409141927.D0F7216A4F0@hub.freebsd.org> References: <200404091419.i39EJCdY042538@repoman.freebsd.org> <20040409141927.D0F7216A4F0@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Fri, Apr 09, 2004 at 07:19:27AM -0700, Maxime Henrion wrote:
> mux 2004/04/09 07:19:12 PDT
>
> FreeBSD src repository
>
> Modified files:
> usr.bin/mt mt.c
> Log:
> Reintroduce a comment that was wrongly removed in revision 1.34.
>
> Revision Changes Path
> 1.35 +4 -0 src/usr.bin/mt/mt.c
>
Err, the weirdness was that different drivers returned different MT_*'s:
- /*
- * XXX This is weird. The st driver reports the tape drive
- * as 0x7 (MT_ISAR - Sun/Archive compatible); the wt driver
- * either reports MT_ISVIPER1 for an Archive tape, or 0x11
- * (MT_ISMFOUR) for other tapes.
- * XXX for the wt driver, rely on it behaving like a "standard"
- * magtape driver.
> Index: src/usr.bin/mt/mt.c
> diff -u src/usr.bin/mt/mt.c:1.34 src/usr.bin/mt/mt.c:1.35
> --- src/usr.bin/mt/mt.c:1.34 Sun Mar 14 04:09:43 2004
> +++ src/usr.bin/mt/mt.c Fri Apr 9 07:19:12 2004
> @@ -44,7 +44,7 @@
> #endif /* not lint */
>
> #include <sys/cdefs.h>
> -__FBSDID("$FreeBSD: /repoman/r/ncvs/src/usr.bin/mt/mt.c,v 1.34 2004/03/14 12:09:43 ru Exp $");
> +__FBSDID("$FreeBSD: /repoman/r/ncvs/src/usr.bin/mt/mt.c,v 1.35 2004/04/09 14:19:12 mux Exp $");
>
> /*
> * mt --
> @@ -312,6 +312,10 @@
> char *t_dsbits; /* "drive status" register */
> char *t_erbits; /* "error" register */
> } tapes[] = {
> + /*
> + * XXX This is weird. The st driver reports the tape drive
> + * as 0x7 (MT_ISAR - Sun/Archive compatible).
> + */
> { MT_ISAR, "SCSI tape drive", 0, 0 },
> { 0, NULL, 0, 0 }
> };
I don't see how this comment applies today and in its current shape.
In any case, I'd appreciate it if you notified me about what I did
wrong before committing.
Cheers,
--
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAdsLYUkv4P6juNwoRAmpHAJ0ed2EHNen/XHAIK/FYz51AxxlzYQCeOkPr
8F9Zpyfv4rXHpKp95S5VQUs=
=aB0U
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040409153552.GC1992>