Date: Thu, 7 Aug 2025 21:59:24 -0700 From: Benjamin Kaduk <bjkfbsd@gmail.com> To: Rick Macklem <rmacklem@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: e3ac01e18eb3 - main - kgssapi: Fix the kgssapi so that it can use MIT Kerberos Message-ID: <CAJ5_RoAh4UACqTJ1GseaVN2NsR3_U5RRQr3WKEQ5p94H_x-0bw@mail.gmail.com> In-Reply-To: <202508072105.577L5nA0081105@gitrepo.freebsd.org> References: <202508072105.577L5nA0081105@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Thu, Aug 7, 2025 at 2:07 PM Rick Macklem <rmacklem@freebsd.org> wrote:
> +enum krb_imp {
> + KRBIMP_UNKNOWN,
> + KRBIMP_HESIOD1,
> + KRBIMP_MIT
> +};
>
>
I only skimmed the diff so far, but I don't think KRBIMP_HESIOD1 makes much
sense as a name -- Hesiod is a directory service of sorts that came out of
MIT's Project Athena (it uses the "HS" DNS record class and we have an
implementation of its functionality in libc) but is otherwise unrelated to
Kerberos. Presumably you wanted something Heimdal-ish here?
-Ben
[-- Attachment #2 --]
<div dir="ltr"><div dir="ltr">On Thu, Aug 7, 2025 at 2:07 PM Rick Macklem <<a href="mailto:rmacklem@freebsd.org">rmacklem@freebsd.org</a>> wrote:</div><div class="gmail_quote gmail_quote_container"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">+enum krb_imp {<br>
+ KRBIMP_UNKNOWN,<br>
+ KRBIMP_HESIOD1,<br>
+ KRBIMP_MIT<br>
+};<br><br></blockquote><div><br></div><div><br></div><div><br></div><div>I only skimmed the diff so far, but I don't think KRBIMP_HESIOD1 makes much sense as a name -- Hesiod is a directory service of sorts that came out of MIT's Project Athena (it uses the "HS" DNS record class and we have an implementation of its functionality in libc) but is otherwise unrelated to Kerberos. Presumably you wanted something Heimdal-ish here?</div><div><br></div><div>-Ben</div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ5_RoAh4UACqTJ1GseaVN2NsR3_U5RRQr3WKEQ5p94H_x-0bw>