Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 08 Apr 2011 14:48:31 +0300
From:      Andriy Gapon <avg@FreeBSD.org>
To:        Garrett Cooper <yanegomi@gmail.com>
Cc:        freebsd-fs@FreeBSD.org, FreeBSD Hackers <freebsd-hackers@FreeBSD.org>, Jeremy Chadwick <freebsd@jdc.parodius.com>
Subject:   Re: retry mounting with ro when rw fails
Message-ID:  <4D9EF60F.1010704@FreeBSD.org>
In-Reply-To: <BANLkTimB9XmkX3V7sMg5dBLSqz=Vxz7nEQ@mail.gmail.com>
References:  <4D9DF375.4080506@FreeBSD.org>	<BANLkTimAyh4-T0gQ1cuQn0nm8m7SHwW5iA@mail.gmail.com>	<20110408000025.GA16252@icarus.home.lan> <BANLkTimB9XmkX3V7sMg5dBLSqz=Vxz7nEQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
on 08/04/2011 05:16 Garrett Cooper said the following:
>     Yeah. It seems like something else like EINVAL (just an example --
> probably a bad one) would be better. Also, please be careful as
> returning ENODEV seems to be UFS-specific:

I wonder how you arrived at that conclusion.
See intro(2) or grep the sources.

> 
>      The following errors can occur for a ufs file system mount:
> 
>      [ENODEV]           A component of ufs_args fspec does not exist.

That documented specific use of ENODEV in UFS doesn't make ENODEV UFS-specific.
Besides I don't ENODEV anywhere under sys/ufs.

>     Also, Tom Rhodes has a similar change to what I suggested on the
> backburner, but it hasn't been 100% fleshed out yet.

I like that approach too.  It has its advantages.
But I don't give up yet on my suggestion.

-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D9EF60F.1010704>