Date: Tue, 31 Dec 2024 21:13:48 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 283516] textproc/ibus: update to 1.5.31 Message-ID: <bug-283516-7788-fyW4Bo3YQn@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-283516-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-283516-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283516 --- Comment #1 from Henry Hu <henry.hu.sh@gmail.com> --- On the high level this looks good, I have a few comments, though: 1. I know vulkan and graphene are listed as 'requirements' in gtk4.pc. Do y= ou think that we should list them as dependencies of this port, though? This port does not use them directly; instead, they're depended upon indire= ctly through GTK4, right? So we possibly should just have GTK4 depend on them? If you check the code, actually gtk2 & gtk3 plugins also use graphene, but they're not listed. I suppose removing them creates warnings in stage-qa? I still lean towards = not having them as direct dependencies, though, at least not vulkan - we do have some code which uses graphene, although the code does not even include its header. I think the code possibly should be fixed upstream... My opinion on this is not very strong, though. If you want to keep them to avoid the warning, I'm okay with that. 2. I think removing the BUILD_DEP on gtk-doc is not fully correct; it shoul= d be there when the DOCS option is enabled, otherwise, it'll be detected as miss= ing during configure, and docs would not be built. 3. This is not relevant to this change, but it seems like that we're missin= g a bunch of html files in the pkg-plist, if the DOCS option is enabled. I don't know why we didn't notice this earlier, but we should install them,= I think. This is discovered through `make check-plist`. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-283516-7788-fyW4Bo3YQn>