Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Mar 2002 17:53:03 +0100
From:      Poul-Henning Kamp <phk@critter.freebsd.dk>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/sys disklabel.h 
Message-ID:  <45547.1016902383@critter.freebsd.dk>
In-Reply-To: Your message of "Sun, 24 Mar 2002 03:48:58 %2B1100." <20020324032036.T39700-100000@gamplex.bde.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20020324032036.T39700-100000@gamplex.bde.org>, Bruce Evans writes:
>On Sat, 23 Mar 2002, Poul-Henning Kamp wrote:
>
>> phk         2002/03/23 08:03:13 PST
>>
>>   Modified files:
>>     sys/sys              disklabel.h
>>   Log:
>>   Hide the ugly d_boot[01] from the kernel.
>>
>>   Revision  Changes    Path
>>   1.71      +4 -0      src/sys/sys/disklabel.h
>
>This reintroduces the alignment/padding problems that were fixed by
>removing the corresponding hiding in rev.1.35.  It typically makes
>"struct disklabel" smaller in userland than in the kernel on 64-bit
>machines.  E.g., on alphas, the struct size was 280 in both places,
>but this change makes it 276 in the kernel.  It would be much more
>fatal on machines with 128-bit alignment requirements for pointers
>or 128-bit pointers since then d_boot[01] would not be naturally
>aligned and/or would take more space than d_packname.

Argh, damn.  Didn't think of the alignment.  Backing out.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45547.1016902383>