Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 5 Sep 2025 22:57:24 +0100
From:      Nuno Teixeira <eduardo@freebsd.org>
To:        Colin Percival <cperciva@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org,  dev-commits-src-main@freebsd.org
Subject:   Re: git: af60084978a4 - main - Add description for WITH_PTHREADS_ASSERTIONS
Message-ID:  <CAFDf7UKymJ_3YefuHzO6ri=_GU44PcDZEQKSmGoMrmrBmxdttw@mail.gmail.com>
In-Reply-To: <202509052136.585La5mx020210@gitrepo.freebsd.org>
References:  <202509052136.585La5mx020210@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000efbb4c063e14ec95
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Colin,

For people that turn off debug on main, should WITH_PTHREADS_ASSERTIONS be
turned off?

e.g.
/etc/src.conf:
WITH_MALLOC_PRODUCTION=3Dyes
WITHOUT_LLVM_ASSERTIONS=3Dyes

Thanks,

Colin Percival <cperciva@freebsd.org> escreveu (sexta, 5/09/2025 =C3=A0(s)
22:36):

> The branch main has been updated by cperciva:
>
> URL:
> https://cgit.FreeBSD.org/src/commit/?id=3Daf60084978a43632c5ab2d6e3aca41b=
e7a658d8c
>
> commit af60084978a43632c5ab2d6e3aca41be7a658d8c
> Author:     Colin Percival <cperciva@FreeBSD.org>
> AuthorDate: 2025-09-05 21:29:51 +0000
> Commit:     Colin Percival <cperciva@FreeBSD.org>
> CommitDate: 2025-09-05 21:35:53 +0000
>
>     Add description for WITH_PTHREADS_ASSERTIONS
>
>     This option is turned on by default in -CURRENT but will be turned of=
f
>     in 15-STABLE; this description will land in the src.conf(5) man page
>     in that branch.
>
>     MFC after:      1 minute
> ---
>  tools/build/options/WITH_PTHREADS_ASSERTIONS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/build/options/WITH_PTHREADS_ASSERTIONS
> b/tools/build/options/WITH_PTHREADS_ASSERTIONS
> new file mode 100644
> index 000000000000..03c15b76fb85
> --- /dev/null
> +++ b/tools/build/options/WITH_PTHREADS_ASSERTIONS
> @@ -0,0 +1 @@
> +Enable debugging assertions in pthreads library.
>
>

--=20
Nuno Teixeira
FreeBSD UNIX:  <eduardo@FreeBSD.org>   Web:  https://FreeBSD.org

--000000000000efbb4c063e14ec95
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hello Colin,</div><div><br></div><div>For people that=
 turn off debug on main, should=C2=A0WITH_PTHREADS_ASSERTIONS be turned off=
?=C2=A0<br></div><div><br></div><div>e.g.</div><div>/etc/src.conf:</div><di=
v>WITH_MALLOC_PRODUCTION=3Dyes<br>WITHOUT_LLVM_ASSERTIONS=3Dyes<br><br></di=
v><div>Thanks,</div></div><br><div class=3D"gmail_quote gmail_quote_contain=
er"><div dir=3D"ltr" class=3D"gmail_attr">Colin Percival &lt;<a href=3D"mai=
lto:cperciva@freebsd.org">cperciva@freebsd.org</a>&gt; escreveu (sexta, 5/0=
9/2025 =C3=A0(s) 22:36):<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">The branch main has been updated by cperciva:<br>
<br>
URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3Daf60084978a43632c=
5ab2d6e3aca41be7a658d8c" rel=3D"noreferrer" target=3D"_blank">https://cgit.=
FreeBSD.org/src/commit/?id=3Daf60084978a43632c5ab2d6e3aca41be7a658d8c</a><b=
r>
<br>
commit af60084978a43632c5ab2d6e3aca41be7a658d8c<br>
Author:=C2=A0 =C2=A0 =C2=A0Colin Percival &lt;cperciva@FreeBSD.org&gt;<br>
AuthorDate: 2025-09-05 21:29:51 +0000<br>
Commit:=C2=A0 =C2=A0 =C2=A0Colin Percival &lt;cperciva@FreeBSD.org&gt;<br>
CommitDate: 2025-09-05 21:35:53 +0000<br>
<br>
=C2=A0 =C2=A0 Add description for WITH_PTHREADS_ASSERTIONS<br>
<br>
=C2=A0 =C2=A0 This option is turned on by default in -CURRENT but will be t=
urned off<br>
=C2=A0 =C2=A0 in 15-STABLE; this description will land in the src.conf(5) m=
an page<br>
=C2=A0 =C2=A0 in that branch.<br>
<br>
=C2=A0 =C2=A0 MFC after:=C2=A0 =C2=A0 =C2=A0 1 minute<br>
---<br>
=C2=A0tools/build/options/WITH_PTHREADS_ASSERTIONS | 1 +<br>
=C2=A01 file changed, 1 insertion(+)<br>
<br>
diff --git a/tools/build/options/WITH_PTHREADS_ASSERTIONS b/tools/build/opt=
ions/WITH_PTHREADS_ASSERTIONS<br>
new file mode 100644<br>
index 000000000000..03c15b76fb85<br>
--- /dev/null<br>
+++ b/tools/build/options/WITH_PTHREADS_ASSERTIONS<br>
@@ -0,0 +1 @@<br>
+Enable debugging assertions in pthreads library.<br>
<br>
</blockquote></div><div><br clear=3D"all"></div><br><span class=3D"gmail_si=
gnature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><d=
iv dir=3D"ltr"><div><font color=3D"#888888">Nuno Teixeira</font></div><div>=
<div><font color=3D"#888888">
FreeBSD UNIX:=C2=A0 &lt;eduardo@FreeBSD.org&gt;=C2=A0 =C2=A0Web:=C2=A0 <a h=
ref=3D"https://FreeBSD.org" rel=3D"noreferrer" target=3D"_blank">https://Fr=
eeBSD.org</a><br></font></div></div></div></div>

--000000000000efbb4c063e14ec95--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UKymJ_3YefuHzO6ri=_GU44PcDZEQKSmGoMrmrBmxdttw>