Date: Fri, 23 Mar 2001 19:11:25 -0800 From: Julian Elischer <julian@elischer.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Archie Cobbs <archie@dellroad.org>, arch@FreeBSD.org Subject: Re: Critical Regions Round II Message-ID: <3ABC105D.E01C0842@elischer.org> References: <XFMail.010323182612.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote:
> Archie said:
> > Shouldn't these be, e.g.,
> >
> > i386_disable_intr(), i386_enable_intr()
> >
> > and
> >
> > ia64_enable_intr(), ia64_disable_intr()
> >
> > That is, it seems like "machine dependent" has a strict meaning,
> > it means: specific to a single (one) architecture.
>
> Sticking all MD stuff under a ${MACHINE_ARCH}_* namespace might be an
> interesting project in the future, but it wouldn't be a small undertaking.
>
> > Or are we expecting to have code that looks like this:
> >
> > #if defined(__i386__) || defined(__ia64__)
> > disable_intr()
> > #endif
> >
> > ??
>
> No, this code should not be used outside of sys/${MACHINE_ARCH}, which is
> mostly how things were (aside from broken things like the joy driver) before
> SMPng.
I think the names should include either md_ or I386_ as a leadin so that people
who are 'copying' to make their own drivers a made fully aware
of what is going on.
--
__--_|\ Julian Elischer
/ \ julian@elischer.org
( OZ ) World tour 2000-2001
---> X_.---._/
v
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3ABC105D.E01C0842>