Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Oct 2010 17:04:21 +0000 (UTC)
From:      Andriy Gapon <avg@FreeBSD.org>
To:        cvs-src-old@freebsd.org
Subject:   cvs commit: src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c
Message-ID:  <201010121704.o9CH4ful099858@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
avg         2010-10-12 17:04:21 UTC

  FreeBSD src repository

  Modified files:
    sys/cddl/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c 
  Log:
  SVN rev 213730 on 2010-10-12 17:04:21Z by avg
  
  zfs + sendfile: do not produce partially valid pages for vnode's tail
  
  Since r212650 and before this change sendfile(2) could produce
  a partially valid page for a trailing portion of a ZFS vnode.
  vm_fault() always wants to see a fully valid page even if it's the last
  page that partially extends beyond vnode's end.  Otherwise it calls
  vop_getpages() to bring in the page.  In the case of ZFS this means
  that the data is read from the page into the same page and this breaks
  checks in ZFS mappedread() - a thread that set VPO_BUSY on the page in
  vm_fault() will get blocked forever waiting for it to be cleared.
  
  Many thanks to Kai and Jeremy for reproducing the issue and providing
  important debugging information and help.
  
  Reported by:    Kai Gallasch <gallasch@free.de>,
                  Jeremy Chadwick <freebsd@jdc.parodius.com>
  Tested by:      Kai Gallasch <gallasch@free.de>,
                  Jeremy Chadwick <freebsd@jdc.parodius.com>
  Reviewed by:    kib
  MFC after:      3 days
  To-Do:          apply the same treatment to tmpfs + sendfile
  
  Revision  Changes    Path
  1.82      +6 -3      src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201010121704.o9CH4ful099858>