Date: Wed, 6 Jan 2010 11:20:02 GMT From: Paul B Mahol <onemda@gmail.com> To: freebsd-net@FreeBSD.org Subject: Re: kern/142197: [ndis] [patch] ndis is missing media status reporting Message-ID: <201001061120.o06BK22H082938@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/142197; it has been noted by GNATS. From: Paul B Mahol <onemda@gmail.com> To: Roman Bogorodskiy <novel@freebsd.org> Cc: bug-followup@freebsd.org, rpaulo@freebsd.org Subject: Re: kern/142197: [ndis] [patch] ndis is missing media status reporting Date: Wed, 6 Jan 2010 11:54:48 +0100 On 1/6/10, Roman Bogorodskiy <novel@freebsd.org> wrote: > Hello, > > Seems like there's a minor problem with that: > > cc1: warnings being treated as errors > /usr/src/sys/modules/if_ndis/../../dev/if_ndis/if_ndis.c: In function > 'ndis_media_status': > /usr/src/sys/modules/if_ndis/../../dev/if_ndis/if_ndis.c:2252: warning: > passing argument 4 of 'ndis_get_info' from incompatible pointer type > *** Error code 1 > > As ndis_get_info accepts 'int', not 'size_t', so after applying this: > > --- if_ndis.c.orig 2010-01-06 12:15:17.000000000 +0300 > +++ if_ndis.c 2010-01-06 12:17:03.000000000 +0300 > @@ -2243,7 +2243,7 @@ > struct ieee80211vap *vap = ifp->if_softc; > struct ndis_softc *sc = vap->iv_ic->ic_ifp->if_softc; > uint32_t txrate; > - size_t len; > + int len; > > if (!NDIS_INITIALIZED(sc)) > return; > > it compiles fine. > > Roman Bogorodskiy > Right, I generated patch from my git repo which is less broken then code in CURRENT. ndis_get_info should really use size_t and not int for *buflen -- Paul B Mahol
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001061120.o06BK22H082938>