Date: Fri, 8 Jan 2021 07:54:41 -0700 From: Warner Losh <imp@bsdimp.com> To: Mateusz Piotrowski <0mp@freebsd.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 74bd20769706 - main - Reference newfs_msdos(8) from the newfs(8) manual Message-ID: <CANCZdfrGAhcmdQvsLWepEx--sRD7gan2zVCbFsbBKOwNcM0Cow@mail.gmail.com> In-Reply-To: <52e99dc8-cd75-a2ab-7670-b81d8aaa8134@FreeBSD.org> References: <202101070924.1079OE4g081849@gitrepo.freebsd.org> <X/dQAejFbWFxM8Uu@kib.kiev.ua> <52e99dc8-cd75-a2ab-7670-b81d8aaa8134@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
On Fri, Jan 8, 2021 at 5:51 AM Mateusz Piotrowski <0mp@freebsd.org> wrote: > Hello Konstantin, > > On 1/7/21 7:16 PM, Konstantin Belousov wrote: > > On Thu, Jan 07, 2021 at 09:24:14AM +0000, Mateusz Piotrowski wrote: > >> The branch main has been updated by 0mp (doc, ports committer): > >> > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=74bd20769706041108a573601cf0b61c755bdc56 > >> > >> commit 74bd20769706041108a573601cf0b61c755bdc56 > >> Author: Mateusz Piotrowski <0mp@FreeBSD.org> > >> AuthorDate: 2021-01-07 09:22:20 +0000 > >> Commit: Mateusz Piotrowski <0mp@FreeBSD.org> > >> CommitDate: 2021-01-07 09:24:07 +0000 > >> > >> Reference newfs_msdos(8) from the newfs(8) manual > > Why ? newfs is not the interface to create arbitrary kind of filesystem, > > it is just UFS writer. > > I think that it is beneficial nevertheless. Now users can discover other > newfs_* commands FreeBSD > offers. Also, newfs_msdos(8) already references newfs(8) (there are only > two items in the SEE ALSO > section there, the other one being gpart(8)). > > From my perspective it is not too bad to have this reference in the newfs > manual. It seems like > it's also something some FreeBSD users expect to see in the manual page as > we received a bug report > for that. > > I can revert this patch and also remove newfs(8) from the newfs_msdos > manual while at it if desired. > Perhaps newfs commands are easy enough to find so this patch only hurts > the readability of the manual... > I think it's a good change because many other filesystem manipulation commands will do arbitrary filesystems. Since it breaks this symmetry, having the xref is fine. Warnerhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrGAhcmdQvsLWepEx--sRD7gan2zVCbFsbBKOwNcM0Cow>