Date: Sun, 5 Nov 2017 08:26:35 -0800 From: "Simon J. Gerraty" <sjg@juniper.net> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: "O. Hartmann" <ohartmann@walstatt.org>, <svn-src-head@FreeBSD.org>, <svn-src-all@FreeBSD.org>, <src-committers@FreeBSD.org>, Cy Schubert <Cy.Schubert@komquats.com>, <sjg@juniper.net> Subject: Re: svn commit: r325404 - head/share/mk Message-ID: <13707.1509899195@kaos.jnpr.net> In-Reply-To: <7d0c021d-fe3d-9bea-b088-5e530176288b@FreeBSD.org> References: <201711042102.vA4L2RuR063978@repo.freebsd.org> <20171104223133.00f5bf30@thor.intern.walstatt.dynvpn.de> <20171105111644.4c294342@thor.intern.walstatt.dynvpn.de> <7d0c021d-fe3d-9bea-b088-5e530176288b@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bryan Drewery <bdrewery@FreeBSD.org> wrote:
> > ${.OBJDIR} =3D=3D /${RELDIR})) make[6]: Fatal errors encountered -- ca=
nnot continue make[6]:
> > stopped
> > in /usr/obj/usr/src/amd64.amd64/sys/THOR/usr/ports/emulators/virtualbo=
x-ose-kmod/work/VirtualBox-5.2.0/out/freebsd.amd64/release/bin/src/vboxdrv
> > *** Error code 1
> =
> Weird, can you try this please? http://dpaste.com/3HR1EQH.txt
> =
That will work, but you could remove the check for SRCTOP since it isn't
used in the conditional.
FWIW this is happening because make is being run from within OBJTOP
during kernel module build, and thus the logic in src.sys.env.mk
isn't defining RELDIR.
If OBJTOP were defined (it is in my case) the following
which is similar to what we have in our internal trees
would fix it.
In the FreeBSD tree though OBJTOP may not defined until some time later.
And if you want to .export it you need to use .export-env and play games
to get it into a form that will work as TARGET_SPEC_VARS change values.
Index: share/mk/src.sys.env.mk
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- share/mk/src.sys.env.mk (revision 325436)
+++ share/mk/src.sys.env.mk (working copy)
@@ -10,6 +10,8 @@
RELTOP=3D .
.elif ${.CURDIR:M${SRCTOP}/*}
RELDIR:=3D ${.CURDIR:S,${SRCTOP}/,,}
+.elif ${.CURDIR:M${OBJTOP}/*}
+RELDIR:=3D ${.CURDIR:S,${OBJTOP}/,,}
.endif
RELTOP?=3D ${RELDIR:C,[^/]+,..,g}
RELOBJTOP?=3D ${RELTOP}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13707.1509899195>