Date: Thu, 22 Apr 2021 13:00:16 +0200 From: Michael Gmelin <grembo@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5b7c17856512 - main - git hooks: Rework authorship instructions. Message-ID: <B6C4775F-8A8F-401B-AA2D-6913EC6BA782@freebsd.org> In-Reply-To: <20210422104914.d3kwtrwl2jovwvu2@aching.in.mat.cc> References: <20210422104914.d3kwtrwl2jovwvu2@aching.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 22. Apr 2021, at 12:49, Mathieu Arnold <mat@freebsd.org> wrote: >=20 > =EF=BB=BFOn Thu, Apr 22, 2021 at 10:43:46AM +0000, Alexey Dokuchaev wrote:= >>> On Thu, Apr 22, 2021 at 12:16:16PM +0200, Mathieu Arnold wrote: >>> On Thu, Apr 22, 2021 at 12:10:26PM +0200, Michael Gmelin wrote: >>>> ... >>>> I agree that author should only be used if a submission is applied >>>> unaltered (pull request/git patch). >>>=20 >>> Submitted by has always been for submission that was unaltered (or only >>> slightly altered) if it was only the basis of the work, then "submitted >>> by" is not to be used, in those cases, reported by is the correct >>> choice. >>=20 >> Not really, no. "PR:/Submitted by:" is canonical combination, yet most >> of us modify submitted patches because they almost always need more work.= >=20 > Then you are misusing Submitted by. Submitted by was supposed to be > used when you committed something that was, well, submitted by someone > else. If the work is yours, and that you based your work on someone > else's, then, it is not submitted by them. >=20 I don=E2=80=99t think git author should be used if anything is altered, incl= uding the commit message (as a contributor, I wouldn=E2=80=99t want to give a= nyone the impression that the rude ramblings of a grumpy committer are to be= attributed to me). That doesn=E2=80=99t map well to our model though. I ass= ume the git working group discussed this in detail, especially when it comes= to accepting pull requests over various channels. -m > --=20 > Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B6C4775F-8A8F-401B-AA2D-6913EC6BA782>