Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Nov 2013 15:45:30 +0100
From:      =?ISO-8859-1?Q?Jean-S=E9bastien_P=E9dron?= <dumbbell@FreeBSD.org>
To:        Michael Butler <imb@protected-networks.net>,  freebsd-current <freebsd-current@freebsd.org>
Subject:   Re: SVN r258549 breaks -current compiled with gcc
Message-ID:  <5293628A.6080508@FreeBSD.org>
In-Reply-To: <52935B26.9010105@protected-networks.net>
References:  <52935B26.9010105@protected-networks.net>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--tsNu2uBWFEXPwoB2s6TED9han7bgqAtEb
Content-Type: multipart/mixed;
 boundary="------------040905040508070108060501"

This is a multi-part message in MIME format.
--------------040905040508070108060501
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 25.11.2013 15:13, Michael Butler wrote:
> --- drm_linux_list_sort.o ---
> cc1: warnings being treated as errors
> /usr/src/sys/modules/drm2/drm2/../../../dev/drm2/drm_linux_list_sort.c:=

> In function 'drm_le_cmp':
> /usr/src/sys/modules/drm2/drm2/../../../dev/drm2/drm_linux_list_sort.c:=
45:
> warning: cast discards qualifiers from pointer target type

Hello!

Can you try the attached patch?

I got rid of __DECONST() because clang didn't complain, sorry...

--=20
Jean-S=E9bastien P=E9dron

--------------040905040508070108060501
Content-Type: text/x-patch;
 name="drm_linux_list_sort-deconst.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename="drm_linux_list_sort-deconst.patch"

diff --git a/sys/dev/drm2/drm_linux_list_sort.c b/sys/dev/drm2/drm_linux_=
list_sort.c
index ae4cd64..19c5c9e 100644
--- a/sys/dev/drm2/drm_linux_list_sort.c
+++ b/sys/dev/drm2/drm_linux_list_sort.c
@@ -42,8 +42,8 @@ drm_le_cmp(void *priv, const void *d1, const void *d2)
 	struct drm_list_sort_thunk *thunk;
=20
 	thunk =3D priv;
-	le1 =3D *(struct list_head **)d1;
-	le2 =3D *(struct list_head **)d2;
+	le1 =3D *(__DECONST(struct list_head **, d1));
+	le2 =3D *(__DECONST(struct list_head **, d2));
 	return ((thunk->cmp)(thunk->priv, le1, le2));
 }
=20

--------------040905040508070108060501--

--tsNu2uBWFEXPwoB2s6TED9han7bgqAtEb
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlKTYpIACgkQa+xGJsFYOlOZ3QCguc2wZe+iHUAZjyOnALmatY0z
4rEAoNRIaWM4LcZa+nnXQWavccuTgKsH
=JsTs
-----END PGP SIGNATURE-----

--tsNu2uBWFEXPwoB2s6TED9han7bgqAtEb--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5293628A.6080508>