Date: Thu, 6 Dec 2018 12:12:14 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Joseph Mingrone <jrm@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r486753 - head/cad/gmsh Message-ID: <20181206121214.GA23700@FreeBSD.org> In-Reply-To: <201812061155.wB6Bt0hZ079960@repo.freebsd.org> References: <201812061155.wB6Bt0hZ079960@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 06, 2018 at 11:55:00AM +0000, Joseph Mingrone wrote: > New Revision: 486753 > URL: https://svnweb.freebsd.org/changeset/ports/486753 > > Log: > cad/gmsh: Update to 4.0.6 > > Upstream change log: > https://gitlab.onelab.info/gmsh/gmsh/blob/master/CHANGELOG.txt > > -BROKEN_FreeBSD_12_i386= fails to build on FreeBSD 12 i386 due to a clang bug: https://llvm.org/bugs/show_bug.cgi?id=21903 > -BROKEN_FreeBSD_13_i386= fails to build on FreeBSD 13 i386 due to a clang bug: https://llvm.org/bugs/show_bug.cgi?id=21903 It would be nice to explicitly acknowledge in the commit log that it builds fine on i386 now, and these lines were not removed by accident. > -MAKE_JOBS_UNSAFE= yes > - I didn't find anything about parallel build fixes in the changelog, and commit message does not mention it as well. It is expected that when -jX unsafe issue it fixed (and thus MAKE_JOBS_UNSAFE removed), an approximate explanation is provided in the commit log. People often try parallel builds locally and they seem fine, while the problem might just not so easily manifest itself. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181206121214.GA23700>