Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 May 2016 09:59:36 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r415135 - in head/editors/gate: . files
Message-ID:  <20160514095935.GA29838@FreeBSD.org>
In-Reply-To: <201605131901.u4DJ1R4h060511@repo.freebsd.org>
References:  <201605131901.u4DJ1R4h060511@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 13, 2016 at 07:01:27PM +0000, Baptiste Daroussin wrote:
> New Revision: 415135
> URL: https://svnweb.freebsd.org/changeset/ports/415135
> 
> Log:
>   Prevent collision with getline(3)
> ...
> --- head/editors/gate/Makefile	Fri May 13 18:59:03 2016	(r415134)
> +++ head/editors/gate/Makefile	Fri May 13 19:01:27 2016	(r415135)
> @@ -15,6 +15,7 @@ RUN_DEPENDS=	aspell:textproc/aspell
>  
>  USES=		ncurses
>  GNU_CONFIGURE=	yes
> +USE_CSTD=	gnu89

Was this change indented?

> --- head/editors/gate/files/patch-configure	Fri May 13 18:59:03 2016	(r415134)
> +++ head/editors/gate/files/patch-configure	Fri May 13 19:01:27 2016	(r415135)
> @@ -9,3 +9,12 @@
>   LIBS="-l$i  $ac_func_search_save_LIBS"
>   cat > conftest.$ac_ext <<EOF
>   #line 1773 "configure"
> +@@ -2123,7 +2123,7 @@ res_datadir=`eval "echo $datadir"`
> + prefix=$gate_prefix
> + 
> + cat >> confdefs.h <<EOF
> +-#define HELP_FILE "${res_datadir}/gate.help"
> ++#define HELP_FILE "/usr/local/share/gate/gate.help"

This looks bogus: there is 's|$${res_datadir}|${DATADIR}|' ${WRKSRC}/configure
line in the port's Makefile (then again, it's probably bogus as well because
of res_datadir=`eval "echo $datadir"` line in the configure script.  (Whoever
ported it was not very careful.)

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160514095935.GA29838>