Date: Thu, 22 Apr 2021 13:02:33 +0200 From: Michael Gmelin <grembo@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5b7c17856512 - main - git hooks: Rework authorship instructions. Message-ID: <6F9BF9EF-BA78-4E47-9A1C-3A022E2B6ED7@freebsd.org> In-Reply-To: <YIFWdO5pTJCu45qa@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
> On 22. Apr 2021, at 12:57, Alexey Dokuchaev <danfe@freebsd.org> wrote:
>
> On Thu, Apr 22, 2021 at 12:49:14PM +0200, Mathieu Arnold wrote:
>>> On Thu, Apr 22, 2021 at 10:43:46AM +0000, Alexey Dokuchaev wrote:
>>> On Thu, Apr 22, 2021 at 12:16:16PM +0200, Mathieu Arnold wrote:
>>>> On Thu, Apr 22, 2021 at 12:10:26PM +0200, Michael Gmelin wrote:
>>>>> ...
>>>>> I agree that author should only be used if a submission is applied
>>>>> unaltered (pull request/git patch).
>>>>
>>>> Submitted by has always been for submission that was unaltered (or only
>>>> slightly altered) if it was only the basis of the work, then "submitted
>>>> by" is not to be used, in those cases, reported by is the correct
>>>> choice.
>>>
>>> Not really, no. "PR:/Submitted by:" is canonical combination, yet most
>>> of us modify submitted patches because they almost always need more work.
>>
>> Then you are misusing Submitted by. Submitted by was supposed to be
>> used when you committed something that was, well, submitted by someone
>> else. If the work is yours, and that you based your work on someone
>> else's, then, it is not submitted by them.
>
> No: "submitted" literally means there was actionable submission, i.e.
> a patch. It could be good enough to be committed as is (rarely), or
> require various amounts of polishing. Regardless of its quality, it
> is still not merely a "report" as you would suggest. "Reports" are
> sent by portscout or pkg-fallout.
Users also send bug reports. I agree that it’s good to distinguish between reporting ("it’s broken"), submitting a patch ("this fixed it for me"), and accepting a patch unaltered ("this fixes it for everyone in a clean way").
-m
>
> ./danfe
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6F9BF9EF-BA78-4E47-9A1C-3A022E2B6ED7>