Date: Tue, 6 May 2014 17:27:45 -0600 From: Warner Losh <imp@bsdimp.com> To: John-Mark Gurney <jmg@funkthat.com> Cc: Hans Petter Selasky <hps@selasky.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Marius Strobl <marius@alchemy.franken.de> Subject: Re: svn commit: r265359 - head/sys/modules/sound/sound Message-ID: <BF6FB8AE-51C1-4D14-8BAF-25267D31729E@bsdimp.com> In-Reply-To: <20140506225551.GD43976@funkthat.com> References: <201405051431.s45EVZ2q027729@svn.freebsd.org> <7745BD19-5BAE-47BD-8DE4-10CF7E23FA9D@gmail.com> <53690381.9040909@selasky.org> <20140506160154.GA679@alchemy.franken.de> <20140506225551.GD43976@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On May 6, 2014, at 4:55 PM, John-Mark Gurney <jmg@funkthat.com> wrote: > Marius Strobl wrote this message on Tue, May 06, 2014 at 18:01 +0200: >> On Tue, May 06, 2014 at 05:45:05PM +0200, Hans Petter Selasky wrote: >>> On 05/05/14 22:39, Warner Losh wrote: >>>> >>>> On May 5, 2014, at 8:31 AM, Hans Petter Selasky <hselasky@freebsd.org> wrote: >>>> >>>>> Author: hselasky >>>>> Date: Mon May 5 14:31:34 2014 >>>>> New Revision: 265359 >>>>> URL: http://svnweb.freebsd.org/changeset/base/265359 >>>>> >>>>> Log: >>>>> Build the kernel sound module without ISA DMA support for ARM and MIPS >>>>> platforms, because these platforms do not implement the ISA DMA >>>>> API. Else the sound modules cannot be loaded when running these >>>>> platforms. >>>>> >>>>> MFC after: 2 weeks >>>>> >>>>> Modified: >>>>> head/sys/modules/sound/sound/Makefile >>>>> >>>>> Modified: head/sys/modules/sound/sound/Makefile >>>>> ============================================================================== >>>>> --- head/sys/modules/sound/sound/Makefile Mon May 5 11:50:52 2014 (r265358) >>>>> +++ head/sys/modules/sound/sound/Makefile Mon May 5 14:31:34 2014 (r265359) >>>>> @@ -44,7 +44,8 @@ CLEANFILES+= feeder_eq_gen.h feeder_rate >>>>> >>>>> EXPORT_SYMS= YES # XXX evaluate >>>>> >>>>> -.if ${MACHINE_CPUARCH} == "sparc64" || ${MACHINE_CPUARCH} == "powerpc" >>>>> +.if ${MACHINE_CPUARCH} == "sparc64" || ${MACHINE_CPUARCH} == "powerpc" || \ >>>>> + ${MACHINE_CPUARCH} == "arm" || ${MACHINE_CPUARCH} == "mips" >>>>> # Create an empty opt_isa.h in order to keep kmod.mk from linking in an >>>>> # existing one from KERNBUILDDIR which possibly has DEV_ISA defined so >>>>> # sound.ko is always built without isadma support. >>>> >>>> Rather than an opt-in approach here, why not lust list the three that have it since >>>> they are the only ones that will ever have it? >>>> >>>> Warner >>>> >>> >>> Hi, >>> >>> Maybe the sound DMA file belongs in its own module? >>> >> >> It's not just sndbuf_dma.c but also the #ifdef'ed DEV_ISA code in >> channel.c on architectures that have ISA but not ISA DMA support, >> hence the current kludge. > > I thought busdma was suppose to abstract all of this away? Is it > just that this was never complete? or? Never completed for ISA DMA… Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTaW/xAAoJEGwc0Sh9sBEAIrIQAIOz6uEAmEuAdannwagb0w9O jwYuKq0eRb6kVnsONXkTUgCgMe3uWpuhvEjI/J15VUomy8Ax1G+fin9MP6OWIYSe Xq+0BpK+BT5NlKDvYtCyK7Vl/EOj/1EaOhgVc1gTuHy+nIIbj+XYBZcQeqqDnfh3 F0wGLwS7kaCmTR8ZeW9Ub/a0xm+70LjSa+kcuJcM9e9xVyYVMlGh+JroorL4rDuu hPE4N/2Bbny3wKrqm+PV4yu5XXag2zQSkD11ejo4/F5ojfl2FU/c75ZEgOpu0bD8 g52dyplhNJTClY01T9DjtkwIajcr7iwBvRELZEXxuwPhURnYmI9QkdO4icivU11W SdXJiA7ahUbkXP3Te/4N2MYw7FA2JvVueqfo00FUJhC3BJj0J6RR5OYJlfr+RfRM JwXgrlhFdJLTb5lcTDjXccHBZF2zni9gepgV0X5Uq2hKBhJXDcbJdcTa9DuTAevU 7SxRnzX5UfanypB8Urxm1xFBIRIHOf1WmRVxVwOA2F9QLayisBfAzGQkWjl10/yn iMtYybnNQLRnMxw0eaYkxZH8gJmrcbLTx0zE9pwrzV/AXzqh5EwxBPVuxNsSlaos 7JZv28gaayxo6DUc76fY7h/F3C/aw2LVsALffK3O2a9wGUmHIwgoOOfNHJhwNqGJ XVdkJvz88spkGYRweAON =TyIs -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BF6FB8AE-51C1-4D14-8BAF-25267D31729E>