Date: Sun, 28 Dec 2003 14:00:33 -0800 (PST) From: Nate Lawson <nate@root.org> To: "Brian F. Feldman" <green@FreeBSD.org> Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c Message-ID: <20031228135955.J9675@root.org> In-Reply-To: <200312261826.hBQIQkAX060681@green.bikeshed.org> References: <200312261826.hBQIQkAX060681@green.bikeshed.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 26 Dec 2003, Brian F. Feldman wrote:
> Sam Leffler <sam@errno.com> wrote:
> > On Friday 26 December 2003 10:09 am, Brian Feldman wrote:
> > > green 2003/12/26 10:09:35 PST
> > >
> > > FreeBSD src repository
> > >
> > > Modified files:
> > > sys/net if.c
> > > Log:
> > > Don't truncate the interface name in ifunit(). It's now possible to
> > > query "very long interface names", e.g.:
> > > ndis_atheros0: flags=8847<UP,BROADCAST,DEBUG,RUNNING,SIMPLEX,MULTICAST>
> > > mtu 1500
> >
> > I'm not sure this works out well as I believe user-level apps like netstat
> > assume interface names are short max-lengthed strings. I've been using the
> > ndis stuff (great work btw) and was thinking instead that it would be nice to
> > customize the device by specifying the name at config time.
> >
> > I think you need to discuss changes like this before committing them.
>
> They are still short max-length strings. ifunit() wasn't accounting for the
> "dev/" it was appending when it searches for a given interface, so it was
> limiting things to IFNAMSIZE - 4 accidentally.
Hmmm, then shouldn't you use "dev/" instead of "net"?
+ char namebuf[IFNAMSIZ + sizeof("net")]; /* XXX net_cdevsw.d_name */
-Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031228135955.J9675>