Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 03 Dec 2018 23:43:41 -0800
From:      Kirk McKusick <mckusick@mckusick.com>
To:        Don Lewis <truckman@FreeBSD.org>
Cc:        freebsd-fs@FreeBSD.org
Subject:   Re: stuck with ufs CHECK-HASH errors
Message-ID:  <201812040743.wB47hf6Z092773@chez.mckusick.com>
In-Reply-To: <tkrat.2f594d1b2546d371@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> Date: Mon, 3 Dec 2018 23:08:50 -0800 (PST)
> From: Don Lewis <truckman@FreeBSD.org>
> Subject: Re: stuck with ufs CHECK-HASH errors
> To: Kirk McKusick <mckusick@mckusick.com>
> cc: freebsd-fs@FreeBSD.org
> 
> On  3 Dec, Kirk McKusick wrote:
> > I am working on a fix. Hopefully have it in no more than a day.
> 
> I figured out that ufs_disk_fillout() and therefore sbread() in libufs
> is never getting called.  Therefore the superblock used by cgput() is
> all zeros.  If I change the call to ufs_disk_fillout_blank() in setup()
> to ufs_disk_fillout() then things appear to work much better.

Yeah, that was my first attempt at a fix, but if the superblock has
a check-hash error, then fsck_ffs bails out at the ufs_disk_fillout()
call without getting down to the code that looks for alternate superblocks.
So, cannot use your fix long-term.

	Kirk McKusick



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201812040743.wB47hf6Z092773>