Date: Sat, 11 Nov 2017 12:16:19 +0000 (UTC) From: Konstantin Belousov <kib@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: svn commit: r325712 - stable/11/lib/libc/stdlib Message-ID: <201711111216.vABCGJ3b090158@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: kib Date: Sat Nov 11 12:16:19 2017 New Revision: 325712 URL: https://svnweb.freebsd.org/changeset/base/325712 Log: MFC r325389: C++17 requires quick_exit(3) to be async-signal safe. Modified: stable/11/lib/libc/stdlib/quick_exit.3 stable/11/lib/libc/stdlib/quick_exit.c Directory Properties: stable/11/ (props changed) Modified: stable/11/lib/libc/stdlib/quick_exit.3 ============================================================================== --- stable/11/lib/libc/stdlib/quick_exit.3 Sat Nov 11 12:12:26 2017 (r325711) +++ stable/11/lib/libc/stdlib/quick_exit.3 Sat Nov 11 12:16:19 2017 (r325712) @@ -24,7 +24,7 @@ .\" .\" $FreeBSD$ .\" -.Dd December 13, 2014 +.Dd November 4, 2017 .Dt QUICK_EXIT 3 .Os .Sh NAME @@ -44,6 +44,17 @@ with .Xr at_quick_exit 3 but not any C++ destructors or cleanup code registered with .Xr atexit 3 . +The +.Xr stdio 3 +file buffers are not flushed. +.Pp +The function +.Fn quick_exit +is +.Em async-signal safe +when the functions registered with +.Xr at_quick_exit 3 +are. .Sh RETURN VALUES The .Fn quick_exit Modified: stable/11/lib/libc/stdlib/quick_exit.c ============================================================================== --- stable/11/lib/libc/stdlib/quick_exit.c Sat Nov 11 12:12:26 2017 (r325711) +++ stable/11/lib/libc/stdlib/quick_exit.c Sat Nov 11 12:16:19 2017 (r325712) @@ -26,6 +26,8 @@ * $FreeBSD$ */ +#include <sys/types.h> +#include <machine/atomic.h> #include <stdlib.h> #include <pthread.h> @@ -60,6 +62,7 @@ at_quick_exit(void (*func)(void)) h->cleanup = func; pthread_mutex_lock(&atexit_mutex); h->next = handlers; + __compiler_membar(); handlers = h; pthread_mutex_unlock(&atexit_mutex); return (0); @@ -74,7 +77,9 @@ quick_exit(int status) * XXX: The C++ spec requires us to call std::terminate if there is an * exception here. */ - for (h = handlers; NULL != h; h = h->next) + for (h = handlers; NULL != h; h = h->next) { + __compiler_membar(); h->cleanup(); + } _Exit(status); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201711111216.vABCGJ3b090158>