Date: Mon, 5 May 2025 07:29:02 -0600 From: Warner Losh <imp@bsdimp.com> To: Olivier Certner <olce@freebsd.org> Cc: "Piotr P. Stefaniak" <pstef@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-branches@freebsd.org Subject: Re: git: 154ccb0196cd - stable/14 - ps(1): Update some options' conformance/practice comments Message-ID: <CANCZdfrBtR2WSkv8zD1BjBAi-bqhdXwy2Do82Kt8Gb9OL7ZmMw@mail.gmail.com> In-Reply-To: <2988597.slGk94SIus@ravel> References: <202505011951.541JpiQV068751@gitrepo.freebsd.org> <aBXN1oednpVU4yav@freefall.freebsd.org> <2988597.slGk94SIus@ravel>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, May 5, 2025, 6:13 AM Olivier Certner <olce@freebsd.org> wrote: > > >- /*- > > >+ /* > > > > No opinion on which it should be, but the minus character is meaningful > > within the context of indent(1) - it won't reformat "block" comments. > > Thanks for pointing that out, I didn't know. I think removing them was > OK, as these block comments are really nothing special. Actually, I > probably should have reformatted them to eliminate the margin for all but > the first line. > Almost nobody uses indent these days on a regular basis. We can drop it for that reason alone, even if the comments were formatted by hand... we likely need to start tagging those with clang format tags.. Warner [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 5, 2025, 6:13 AM Olivier Certner <<a href="mailto:olce@freebsd.org" target="_blank" rel="noreferrer">olce@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">> >- /*-<br> > >+ /*<br> > <br> > No opinion on which it should be, but the minus character is meaningful<br> > within the context of indent(1) - it won't reformat "block" comments.<br> <br> Thanks for pointing that out, I didn't know. I think removing them was OK, as these block comments are really nothing special. Actually, I probably should have reformatted them to eliminate the margin for all but the first line.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Almost nobody uses indent these days on a regular basis. We can drop it for that reason alone, even if the comments were formatted by hand... we likely need to start tagging those with clang format tags..</div><div dir="auto"><br></div><div dir="auto">Warner</div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrBtR2WSkv8zD1BjBAi-bqhdXwy2Do82Kt8Gb9OL7ZmMw>